Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the actionBrowser to RSC client layering issue #57842

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Remove the actionBrowser to RSC client layering issue #57842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af6b056
remove the actionBrowser -> client layering issue
shuding Oct 31, 2023
1338723
Merge branch 'canary' into shu/6c13
kodiakhq[bot] Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions packages/next/src/build/webpack/loaders/next-flight-loader/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import {
RSC_MOD_REF_PROXY_ALIAS,
WEBPACK_LAYERS,
} from '../../../../lib/constants'
import { RSC_MOD_REF_PROXY_ALIAS } from '../../../../lib/constants'
import { RSC_MODULE_TYPES } from '../../../../shared/lib/constants'
import { warnOnce } from '../../../../shared/lib/utils/warn-once'
import { getRSCModuleInformation } from '../../../analysis/get-page-static-info'
Expand Down Expand Up @@ -29,31 +26,10 @@ export default function transformSource(

// A client boundary.
if (buildInfo.rsc?.type === RSC_MODULE_TYPES.client) {
const issuerLayer = this._module.layer
const sourceType = this._module?.parser?.sourceType
const detectedClientEntryType = buildInfo.rsc.clientEntryType
const clientRefs = buildInfo.rsc.clientRefs!

if (issuerLayer === WEBPACK_LAYERS.actionBrowser) {
// You're importing a Server Action module ("use server") from a client module
// (hence you're on the actionBrowser layer), and you're trying to import a
// client module again from it. This is not allowed because of cyclic module
// graph.

// We need to only error for user code, not for node_modules/Next.js internals.
// Things like `next/navigation` exports both `cookies()` and `useRouter()`
// and we shouldn't error for that. In the future we might want to find a way
// to only throw when it's used.
if (!this.resourcePath.includes('node_modules')) {
this.callback(
new Error(
`You're importing a Client Component ("use client") from another Client Component imported Server Action file ("use server"). This is not allowed due to cyclic module graph between Server and Client.\nYou can work around it by defining and passing this Server Action from a Server Component into the Client Component via props.`
)
)
return
}
}

// It's tricky to detect the type of a client boundary, but we should always
// use the `module` type when we can, to support `export *` and `export from`
// syntax in other modules that import this client boundary.
Expand Down