Current behavior of import conditions #66829
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| 'use client' | ||
| import * as React from 'react' | ||
| import * as react from 'library-with-exports/react' | ||
| import * as serverFavoringBrowser from 'library-with-exports/server-favoring-browser' | ||
| import * as serverFavoringEdge from 'library-with-exports/server-favoring-edge' | ||
|
|
||
| export default function ClientPage({ | ||
| action, | ||
| server, | ||
| }: { | ||
| action: () => Promise<Record<string, string>> | ||
| server: unknown | ||
| }) { | ||
| const [actionValue, formAction, isPending] = React.useActionState( | ||
| action, | ||
| undefined | ||
| ) | ||
| const [client, setClient] = React.useState<unknown | null>(null) | ||
| React.useEffect(() => { | ||
| setClient({ | ||
| react: react.condition, | ||
| serverFavoringBrowser: serverFavoringBrowser.condition, | ||
| serverFavoringEdge: serverFavoringEdge.condition, | ||
| }) | ||
| }, []) | ||
|
|
||
| return ( | ||
| <form action={formAction}> | ||
| <input type="submit" /> | ||
| <output aria-busy={client === null || isPending}> | ||
| {client === null ? ( | ||
| <pre>{JSON.stringify({ server }, null, 2)}</pre> | ||
| ) : ( | ||
| <pre> | ||
| {JSON.stringify({ server, client, action: actionValue }, null, 2)} | ||
| </pre> | ||
| )} | ||
| </output> | ||
| </form> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import * as react from 'library-with-exports/react' | ||
| import * as serverFavoringBrowser from 'library-with-exports/server-favoring-browser' | ||
| import * as serverFavoringEdge from 'library-with-exports/server-favoring-edge' | ||
| import ClientPage from '../ClientPage' | ||
|
|
||
| export const runtime = 'edge' | ||
|
|
||
| async function action() { | ||
| 'use server' | ||
| return { | ||
| react: react.condition, | ||
| serverFavoringBrowser: serverFavoringBrowser.condition, | ||
| serverFavoringEdge: serverFavoringEdge.condition, | ||
| } | ||
| } | ||
|
|
||
| export default function Page() { | ||
| return ( | ||
| <ClientPage | ||
| action={action} | ||
| server={{ | ||
| react: react.condition, | ||
| serverFavoringBrowser: serverFavoringBrowser.condition, | ||
| serverFavoringEdge: serverFavoringEdge.condition, | ||
| }} | ||
| /> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import * as react from 'library-with-exports/react' | ||
| import * as serverFavoringBrowser from 'library-with-exports/server-favoring-browser' | ||
| import * as serverFavoringEdge from 'library-with-exports/server-favoring-edge' | ||
| import ClientPage from '../ClientPage' | ||
|
|
||
| export const runtime = 'nodejs' | ||
|
|
||
| async function action() { | ||
| 'use server' | ||
| return { | ||
| react: react.condition, | ||
| serverFavoringBrowser: serverFavoringBrowser.condition, | ||
| serverFavoringEdge: serverFavoringEdge.condition, | ||
| } | ||
| } | ||
|
|
||
| export default function Page() { | ||
| return ( | ||
| <ClientPage | ||
| action={action} | ||
| server={{ | ||
| react: react.condition, | ||
| serverFavoringBrowser: serverFavoringBrowser.condition, | ||
| serverFavoringEdge: serverFavoringEdge.condition, | ||
| }} | ||
| /> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import * as react from 'library-with-exports/react' | ||
| import * as serverFavoringBrowser from 'library-with-exports/server-favoring-browser' | ||
| import * as serverFavoringEdge from 'library-with-exports/server-favoring-edge' | ||
|
|
||
| export const runtime = 'edge' | ||
|
|
||
| export function GET() { | ||
| return Response.json({ | ||
| react: react.condition, | ||
| serverFavoringBrowser: serverFavoringBrowser.condition, | ||
| serverFavoringEdge: serverFavoringEdge.condition, | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export default function Root({ children }: { children: React.ReactNode }) { | ||
| return ( | ||
| <html> | ||
| <body>{children}</body> | ||
| </html> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import * as react from 'library-with-exports/react' | ||
| import * as serverFavoringBrowser from 'library-with-exports/server-favoring-browser' | ||
| import * as serverFavoringEdge from 'library-with-exports/server-favoring-edge' | ||
|
|
||
| export const runtime = 'nodejs' | ||
|
|
||
| export function GET() { | ||
| return Response.json({ | ||
| react: react.condition, | ||
| serverFavoringBrowser: serverFavoringBrowser.condition, | ||
| serverFavoringEdge: serverFavoringEdge.condition, | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,228 @@ | ||
| import { nextTestSetup } from 'e2e-utils' | ||
|
|
||
| describe('react version', () => { | ||
| const { next } = nextTestSetup({ | ||
| files: __dirname, | ||
| dependencies: { | ||
| 'library-with-exports': 'link:./library-with-exports', | ||
| }, | ||
| }) | ||
|
|
||
| it('Pages Router page headers with edge runtime', async () => { | ||
| const response = await next.fetch('/pages/edge-page') | ||
|
|
||
| const middlewareHeaders = { | ||
| react: response.headers.get('x-react-condition'), | ||
| serverFavoringBrowser: response.headers.get( | ||
| 'x-server-favoring-browser-condition' | ||
| ), | ||
| serverFavoringEdge: response.headers.get( | ||
| 'x-server-favoring-edge-condition' | ||
| ), | ||
| } | ||
| expect(middlewareHeaders).toEqual({ | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }) | ||
| }) | ||
|
|
||
| it('Pages Router page with edge runtime', async () => { | ||
| const browser = await next.browser('/pages/edge-page') | ||
|
|
||
| const json = await browser.elementByCss('output').text() | ||
| expect(JSON.parse(json)).toEqual({ | ||
| server: { | ||
| react: 'default', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }, | ||
| client: { | ||
| react: 'default', | ||
| serverFavoringBrowser: 'browser', | ||
| serverFavoringEdge: 'browser', | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| it('Pages Router page headers with nodejs runtime', async () => { | ||
| const response = await next.fetch('/pages/node-page') | ||
|
|
||
| const middlewareHeaders = { | ||
| react: response.headers.get('x-react-condition'), | ||
| serverFavoringBrowser: response.headers.get( | ||
| 'x-server-favoring-browser-condition' | ||
| ), | ||
| serverFavoringEdge: response.headers.get( | ||
| 'x-server-favoring-edge-condition' | ||
| ), | ||
| } | ||
| expect(middlewareHeaders).toEqual({ | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }) | ||
| }) | ||
|
|
||
| it('Pages Router page with nodejs runtime after hydration', async () => { | ||
| const browser = await next.browser('/pages/node-page') | ||
|
|
||
| const json = await browser.elementByCss('output').text() | ||
| expect(JSON.parse(json)).toEqual({ | ||
| server: { | ||
| react: 'default', | ||
| serverFavoringBrowser: 'node', | ||
| serverFavoringEdge: 'node', | ||
| }, | ||
| client: { | ||
| react: 'default', | ||
| serverFavoringBrowser: 'browser', | ||
| serverFavoringEdge: 'browser', | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| it('App Router page headers with edge runtime', async () => { | ||
| const response = await next.fetch('/app/edge-page') | ||
|
|
||
| const middlewareHeaders = { | ||
| react: response.headers.get('x-react-condition'), | ||
| serverFavoringBrowser: response.headers.get( | ||
| 'x-server-favoring-browser-condition' | ||
| ), | ||
| serverFavoringEdge: response.headers.get( | ||
| 'x-server-favoring-edge-condition' | ||
| ), | ||
| } | ||
| expect(middlewareHeaders).toEqual({ | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
|
Comment on lines
+99
to
+100
There was a problem hiding this comment. All appearances of |
||
| }) | ||
| }) | ||
|
|
||
| it('App Router page with edge runtime', async () => { | ||
| const browser = await next.browser('/app/edge-page') | ||
|
|
||
| await browser.waitForElementByCss('input[type="submit"]').click() | ||
| await browser.waitForElementByCss('output[aria-busy="false"]') | ||
|
|
||
| const json = await browser.elementByCss('output').text() | ||
| expect(JSON.parse(json)).toEqual({ | ||
| server: { | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }, | ||
| client: { | ||
| react: 'default', | ||
| serverFavoringBrowser: 'browser', | ||
| serverFavoringEdge: 'browser', | ||
| }, | ||
| action: { | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| it('App Router page headers with nodejs runtime', async () => { | ||
| const response = await next.fetch('/app/node-page') | ||
|
|
||
| const middlewareHeaders = { | ||
| react: response.headers.get('x-react-condition'), | ||
| serverFavoringBrowser: response.headers.get( | ||
| 'x-server-favoring-browser-condition' | ||
| ), | ||
| serverFavoringEdge: response.headers.get( | ||
| 'x-server-favoring-edge-condition' | ||
| ), | ||
| } | ||
| expect(middlewareHeaders).toEqual({ | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }) | ||
| }) | ||
|
|
||
| it('App Router page with nodejs runtime', async () => { | ||
| const browser = await next.browser('/app/node-page') | ||
|
|
||
| await browser.waitForElementByCss('input[type="submit"]').click() | ||
| await browser.waitForElementByCss('output[aria-busy="false"]') | ||
|
|
||
| const json = await browser.elementByCss('output').text() | ||
| expect(JSON.parse(json)).toEqual({ | ||
| server: { | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'node', | ||
| serverFavoringEdge: 'node', | ||
| }, | ||
| client: { | ||
| react: 'default', | ||
| serverFavoringBrowser: 'browser', | ||
| serverFavoringEdge: 'browser', | ||
| }, | ||
| action: { | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'node', | ||
| serverFavoringEdge: 'node', | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| it('App Router Route Handler with nodejs runtime', async () => { | ||
| const response = await next.fetch('/node-route') | ||
|
|
||
| const middlewareHeaders = { | ||
| react: response.headers.get('x-react-condition'), | ||
| serverFavoringBrowser: response.headers.get( | ||
| 'x-server-favoring-browser-condition' | ||
| ), | ||
| serverFavoringEdge: response.headers.get( | ||
| 'x-server-favoring-edge-condition' | ||
| ), | ||
| } | ||
| const data = await response.json() | ||
| expect({ middlewareHeaders, data }).toEqual({ | ||
| middlewareHeaders: { | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }, | ||
| data: { | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'node', | ||
| serverFavoringEdge: 'node', | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| it('App Router Route Handler with edge runtime', async () => { | ||
| const response = await next.fetch('/edge-route') | ||
|
|
||
| const middlewareHeaders = { | ||
| react: response.headers.get('x-react-condition'), | ||
| serverFavoringBrowser: response.headers.get( | ||
| 'x-server-favoring-browser-condition' | ||
| ), | ||
| serverFavoringEdge: response.headers.get( | ||
| 'x-server-favoring-edge-condition' | ||
| ), | ||
| } | ||
| const data = await response.json() | ||
| expect({ middlewareHeaders, data }).toEqual({ | ||
| middlewareHeaders: { | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }, | ||
| data: { | ||
| react: 'react-server', | ||
| serverFavoringBrowser: 'worker', | ||
| serverFavoringEdge: 'worker', | ||
| }, | ||
| }) | ||
| }) | ||
| }) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const condition = 'browser' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const condition = 'default' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const condition = 'edge-light' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| declare module 'library-with-exports/react' { | ||
| export const condition: string | ||
| } | ||
|
|
||
| declare module 'library-with-exports/server-favoring-edge' { | ||
| export const condition: string | ||
| } | ||
|
|
||
| declare module 'library-with-exports/server-favoring-browser' { | ||
| export const condition: string | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const condition = 'netlify' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| throw new Error( | ||
| 'Imported entrypoint that should never be used. This is a bug in Next.js' | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const condition = 'node' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that Pages router middleware already uses
react-server