perf(turbopack): Use ResolvedVc for turbopack-core
#73065
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
force-pushed
the
kdy1/resolved-vc-turbopack
branch
from
01aa356
to
02047b3
Compare
kdy1
force-pushed
the
kdy1/resolved-vc-turbopack
branch
from
02047b3
to
9f35866
Compare
kdy1
commented
Nov 25, 2024
| @@ -11,10 +11,10 @@ use crate::ident::AssetIdent; | |||
|
|
|||
| #[turbo_tasks::value(shared)] | |||
| pub struct AnalyzeIssue { | |||
| pub severity: Vc<IssueSeverity>, | |||
| pub severity: ResolvedVc<IssueSeverity>, | |||
| pub source_ident: Vc<AssetIdent>, | |||
There was a problem hiding this comment.
I couldn't use ResolvedVc<T> here because of emit function implementation in the file.
mischnic
reviewed
Nov 25, 2024
| @@ -14,6 +14,7 @@ workspace = true | |||
|
|
|||
| [dependencies] | |||
| anyhow = { workspace = true } | |||
| async-recursion = "1.1.1" | |||
There was a problem hiding this comment.
We shouldn't need this dependency anymore, it can be done with Box::pin: #69762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use
ResolvedVc<T>instead ofVc<T>for struct fields inturbopack-coreWhy?
How?