Allow disabling HTTP request logs in dev server #74349
Open
+229
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
mohsen1
force-pushed
the
add-dev-request-logging-ignoring
branch
from
81f16af to
bc8aed5
Compare
|
IMO, should be called |
|
Tracing and logging are different concepts. Tracing usually involves keeping track of a request journey and storing it somewhere. Logging is simpler, just print requests that are happening. |
huozhi
reviewed
Jan 13, 2025
huozhi
reviewed
Jan 13, 2025
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for edge-ssr.jsDiff too large to display Diff for 5306-HASH.jsDiff too large to display Diff for main-HASH.jsDiff too large to display Diff for app-page-exp..ntime.dev.jsfailed to diffDiff for app-page-exp..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page.runtime.dev.jsfailed to diffDiff for app-page.runtime.prod.jsDiff too large to display Diff for pages-turbo...time.prod.jsDiff too large to display Diff for pages.runtime.dev.jsDiff too large to display Diff for pages.runtime.prod.jsDiff too large to display Diff for server.runtime.prod.jsfailed to diff |
|
The above failure is likely unrelated to my change. It's surprisingly passing on my machine so it might be flaky. I found a bug that is likely causing this instability. This diff should make it more stable diff --git packages/react-refresh-utils/internal/helpers.ts packages/react-refresh-utils/internal/helpers.ts
index fd26cc0599..1f7a63b6e6 100644
--- packages/react-refresh-utils/internal/helpers.ts
+++ packages/react-refresh-utils/internal/helpers.ts
@@ -63,6 +63,11 @@ function registerExportsForReactRefresh(
moduleExports: unknown,
moduleID: string
) {
+ // Skip registration if this module was already registered
+ if (RefreshRuntime.isRegisteredForRefresh(moduleID + ' %exports%')) {
+ return
+ }
+
RefreshRuntime.register(moduleExports, moduleID + ' %exports%')
if (moduleExports == null || typeof moduleExports !== 'object') {
// Exit if we can't iterate over exports.The issue appears to be in the React Refresh implementation. When we add the default export to bar.js, it becomes a React Refresh boundary (due to exporting a component). This causes the module to be initialized twice: |
mohsen1
force-pushed
the
add-dev-request-logging-ignoring
branch
from
48da0ca to
362b62b
Compare
mohsen1
force-pushed
the
add-dev-request-logging-ignoring
branch
2 times, most recently
from
e072846 to
edc2b65
Compare
mohsen1
force-pushed
the
add-dev-request-logging-ignoring
branch
from
4913050 to
908a7a5
Compare
|
@huozhi PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to filter or disable incoming request logs in development. It adds a new
incomingRequestoption tologgingConfig, supporting both a simple boolean toggle and a configurableignore. By default, logs remain enabled, preserving existing behavior.Notes:
•
loggingConfig.incomingRequest = falsefully disables incoming request logs.•
loggingConfig.incomingRequest.ignoreaccepts a regular expressions array to selectively silence logs.• Covered by unit tests (
shouldLogIncomingRequest)Resolves the dev server’s verbose logging problem discussed in #65992 and complements the effort in #67590.