Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next-custom-transforms tests to verify source maps #75005

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

unstubbable
Copy link
Contributor

@unstubbable unstubbable commented Jan 16, 2025

This test suite allows us to quickly verify that the spans that are defined in the SWC transforms yield correct source maps. The output.js and output.js.map files can be used to visualize the source mapping, e.g. at https://evanw.github.io/source-map-visualization/.

For now I'm adding a single fixture for 'use cache' with this PR.

Copy link
Contributor Author

unstubbable commented Jan 16, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@unstubbable unstubbable marked this pull request as ready for review January 16, 2025 21:36
Base automatically changed from kdy1/swc-core-10-2 to canary January 16, 2025 21:45
This allows us to quickly verify that the spans that are defined in the
SWC transforms yield correct source maps. The `output.js` and
`output.js.map` files can be used to visualize the source mapping, e.g.
at https://evanw.github.io/source-map-visualization/.

For now I'm adding a single fixture for `'use cache'` with this PR.
@unstubbable unstubbable force-pushed the hl/next-custom-transforms-source-maps-tests branch from d60442f to a1d9668 Compare January 16, 2025 21:49
@ijjk
Copy link
Member

ijjk commented Jan 16, 2025

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
buildDuration 20.3s 17.5s N/A
buildDurationCached 16.4s 13.6s N/A
nodeModulesSize 418 MB 418 MB N/A
nextStartRea..uration (ms) 440ms 440ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.3 kB 34.3 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
index.html gzip 523 B 524 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 374 kB 374 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 362 kB 362 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 27.6 kB 27.6 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache
vercel/next.js canary vercel/next.js hl/next-custom-transforms-source-maps-tests Change
0.pack gzip 2.1 MB 2.09 MB N/A
index.pack gzip 76.6 kB 75 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: a1d9668

@unstubbable unstubbable merged commit 6090343 into canary Jan 17, 2025
131 checks passed
@unstubbable unstubbable deleted the hl/next-custom-transforms-source-maps-tests branch January 17, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants