Handle DNS lookup failures (#439)

When lookup fails, it throws an exception, that prevent other code from being executed fixes #437
vercel · Jul 2, 2018 · dd3704f · dd3704f
1 parent 250c972
commit dd3704f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/bin/serve.js b/bin/serve.js
@@ -173,10 +173,14 @@ const startEndpoint = (endpoint, config, args) => {
 			localAddress = details;
 		} else if (typeof details === 'object' && details.port) {
 			const address = details.address === '::' ? 'localhost' : details.address;
-			const {address: ip} = await lookup(os.hostname());
 
 			localAddress = `http://${address}:${details.port}`;
-			networkAddress = `http://${ip}:${details.port}`;
+			try {
+				const {address: ip} = await lookup(os.hostname());
+				networkAddress = `http://${ip}:${details.port}`;
+			} catch (err) {
+				console.error(error(`DNS lookup failed: ${err.message}`));
+			}
 		}
 
 		if (isTTY && process.env.NODE_ENV !== 'production') {