Fix invalid exports by changing package type #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feugy
previously approved these changes
Nov 22, 2023
feugy
dismissed
their stale review
Oups, I forgot type:module was not the correct approach.
Apparently, newer version of Next.js pages dir does not support external ESM modules by default
…insights into fix-package-import
|
Closing in favor of #17 Thanks for the work done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 What's in there?
Our build output didn't align with what's stated in the
package.json. This change, makes the ESM file the default, and outputs ".cjs" for CommonJS. tsup docs for reference.This also aligns with how it works in Web Analytics.