Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shorter framework names #18

Conversation

feugy
Copy link
Member

@feugy feugy commented Nov 28, 2023

📓 What's in there?

When reporting vitals and metrics, we should use a shorter framework name to avoid very long values like @vercel/speed-insights/sveltekit

A shorter prefix like vercel should be enough, and will give vercel/next, vercel/sveltekit or vercel/nuxt

🧪 How to test?

Have a try at one of our deployments, with dev tools open on network, filtering for vitals
image

@feugy feugy requested a review from a team November 28, 2023 14:03
Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
speed-insights-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 2:07pm
speed-insights-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 2:07pm
speed-insights-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 2:07pm
speed-insights-sveltekit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 2:07pm
speed-insights-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 2:07pm

Copy link

linear bot commented Nov 28, 2023

ALY-1087 A shorten framework name for @vercel/speed-insights

When reporting vitals and metrics, we should use a shorter framework name to avoid very long values like vercel/speed-insights/sveltekit

A shorter prefix like vercel should be enough, and will give vercel/next, vercel/sveltekit or vercel/nuxt

@feugy
Copy link
Member Author

feugy commented Nov 29, 2023

We concluded that we can afford these long names. At least they are explicit!

@feugy feugy closed this Nov 29, 2023
@tobiaslins tobiaslins deleted the damien/aly-1087-a-shorten-framework-name-for-vercelspeed-insights branch December 7, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant