Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve documentation in turborepo-lsp and turbo-vsc #8199

Merged
merged 1 commit into from
May 28, 2024
Merged

improve documentation in turborepo-lsp and turbo-vsc #8199

merged 1 commit into from
May 28, 2024

Conversation

arlyon
Copy link
Contributor

@arlyon arlyon commented May 22, 2024 •
edited
Loading

Description

Since I am taking a smaller role in the turborepo side, we are overdue some improved docs on how the LSP works. Fleshed out readmes, and added an architecture doc.

Testing Instructions

N/A

@arlyon arlyon requested review from a team as code owners May 22, 2024 23:19
@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 1:35pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 1:35pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:35pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:35pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:35pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:35pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:35pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:35pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:35pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 1:35pm

@arlyon arlyon requested review from mehulkar and tknickman May 22, 2024 23:19
@arlyon Graphite App
Copy link
Contributor Author

arlyon commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @arlyon and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@arlyon arlyon force-pushed the arlyon/lsp-docs branch from 5e804fd to 59ae442 Compare May 22, 2024 23:24
mehulkar
mehulkar approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up! My general feedback is that the text could be shorter / tighter and easier to read. Feel free to take another pass at it or not depending on your other responsibilities :)

packages/turbo-vsc/ARCHITECTURE.md Show resolved Hide resolved
packages/turbo-vsc/ARCHITECTURE.md Show resolved Hide resolved
packages/turbo-vsc/ARCHITECTURE.md Outdated Show resolved Hide resolved
packages/turbo-vsc/ARCHITECTURE.md Outdated Show resolved Hide resolved
packages/turbo-vsc/ARCHITECTURE.md Outdated Show resolved Hide resolved
packages/turbo-vsc/ARCHITECTURE.md Outdated Show resolved Hide resolved
packages/turbo-vsc/src/extension.ts Show resolved Hide resolved
@arlyon arlyon force-pushed the arlyon/lsp-docs branch from ae51f83 to e30621c Compare May 28, 2024 13:33
@arlyon arlyon merged commit 596ee1a into main May 28, 2024
57 of 58 checks passed
@arlyon arlyon deleted the arlyon/lsp-docs branch May 28, 2024 13:37
@arlyon Graphite App
Copy link
Contributor Author

arlyon commented May 28, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arlyon @mehulkar