Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UnsupportedModule plugin #8439

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Jun 11, 2024

This change removes the UnsupportedModule issue module from the codebase.

It was used by the UnsupportedModule resolve plugin in Next.js, but there are no longer any unsupported modules.

This should improve performance as this check was performed during every resolution.

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 8:16pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 8:16pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 8:16pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 8:16pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 8:16pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 8:16pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 8:16pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 8:16pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 8:16pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 8:16pm

Copy link
Member Author

wbinnssmith commented Jun 11, 2024

Copy link
Contributor

github-actions bot commented Jun 11, 2024

⚠️ This change may fail to build next-swc.

Logs

packages/next-swc/crates/next-core/src/next_font/local/mod.rs:73:39: �[38;5;9merror[E0599]: no variant or associated item named `new` found for enum `BeforeResolvePluginCondition` in the current scope
error: could not compile `next-core` (lib) due to 1 previous error

See job summary for details

Copy link
Contributor

github-actions bot commented Jun 11, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jun 11, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/rm-unsupported-plugin branch from f681bdc to 3c0f592 Compare June 12, 2024 20:14
@wbinnssmith wbinnssmith enabled auto-merge (squash) June 12, 2024 20:14
@wbinnssmith wbinnssmith merged commit 15e7a68 into main Jun 12, 2024
50 of 54 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/rm-unsupported-plugin branch June 12, 2024 20:23
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
This change removes the UnsupportedModule issue module from the
codebase.

It was used by the UnsupportedModule resolve plugin in Next.js, but
there are no longer any unsupported modules.

This should improve performance as this check was performed during every
resolution.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
This change removes the UnsupportedModule issue module from the
codebase.

It was used by the UnsupportedModule resolve plugin in Next.js, but
there are no longer any unsupported modules.

This should improve performance as this check was performed during every
resolution.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
This change removes the UnsupportedModule issue module from the
codebase.

It was used by the UnsupportedModule resolve plugin in Next.js, but
there are no longer any unsupported modules.

This should improve performance as this check was performed during every
resolution.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
This change removes the UnsupportedModule issue module from the
codebase.

It was used by the UnsupportedModule resolve plugin in Next.js, but
there are no longer any unsupported modules.

This should improve performance as this check was performed during every
resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants