Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC auto increase memory limit on inefficient GC #8687

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 8, 2024

Description

When GC is inefficient and can't collect enough memory, increase the provided memory limit automatically.
We rather want to consume more memory than requested then crashing or hanging the compilation due to GC.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 9:09pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 9:09pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:09pm

Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jul 8, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jul 8, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra force-pushed the sokra/gc-auto-increase branch from d0cd5a7 to 01eb47e Compare July 15, 2024 06:31
@sokra sokra marked this pull request as ready for review July 15, 2024 06:31
@sokra sokra requested a review from a team as a code owner July 15, 2024 06:31
@sokra sokra requested a review from arlyon July 15, 2024 06:32
@sokra sokra force-pushed the sokra/gc-auto-increase branch from 01eb47e to c847ae0 Compare July 15, 2024 10:32
@sokra sokra changed the base branch from main to sokra/excessive-cells July 15, 2024 10:33
@sokra sokra force-pushed the sokra/gc-auto-increase branch from 52a5ac9 to cb65272 Compare July 24, 2024 08:45
@sokra sokra force-pushed the sokra/excessive-cells branch from f7ec54f to ade4ad5 Compare July 24, 2024 15:38
@sokra sokra force-pushed the sokra/gc-auto-increase branch from cb65272 to 20ed510 Compare July 24, 2024 15:39
@sokra sokra force-pushed the sokra/excessive-cells branch from ade4ad5 to 3589b2e Compare July 24, 2024 18:52
@sokra sokra force-pushed the sokra/gc-auto-increase branch from 20ed510 to b4912c7 Compare July 24, 2024 18:52
@sokra sokra force-pushed the sokra/excessive-cells branch from 3589b2e to 6fda947 Compare July 24, 2024 19:17
@sokra sokra force-pushed the sokra/gc-auto-increase branch from b4912c7 to d343e87 Compare July 24, 2024 19:17
Base automatically changed from sokra/excessive-cells to main July 24, 2024 19:40
@sokra sokra force-pushed the sokra/gc-auto-increase branch from d343e87 to e07d16a Compare July 24, 2024 19:40
sokra added 2 commits July 24, 2024 23:07
GC until memory is reduced by 5%
increase memory limit when needed
@sokra sokra force-pushed the sokra/gc-auto-increase branch from e07d16a to da4453b Compare July 24, 2024 21:07
@sokra sokra merged commit 4b34a31 into main Jul 25, 2024
56 of 59 checks passed
@sokra sokra deleted the sokra/gc-auto-increase branch July 25, 2024 15:32
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

When GC is inefficient and can't collect enough memory, increase the
provided memory limit automatically.
We rather want to consume more memory than requested then crashing or
hanging the compilation due to GC.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

When GC is inefficient and can't collect enough memory, increase the
provided memory limit automatically.
We rather want to consume more memory than requested then crashing or
hanging the compilation due to GC.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

When GC is inefficient and can't collect enough memory, increase the
provided memory limit automatically.
We rather want to consume more memory than requested then crashing or
hanging the compilation due to GC.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

When GC is inefficient and can't collect enough memory, increase the
provided memory limit automatically.
We rather want to consume more memory than requested then crashing or
hanging the compilation due to GC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants