Replace MDX ModuleType with MDX SourceTransform #8766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
the
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
mischnic
force-pushed
the
mischnic/mdx-sourcetransform
branch
from
3f4d578 to
db039d4
Compare
turbo-orchestrator
bot
added
created-by: turbopack
and removed
needs: triage
mischnic
force-pushed
the
mischnic/mdx-sourcetransform
branch
from
db039d4 to
ff83eba
Compare
mischnic
force-pushed
the
mischnic/mdx-sourcetransform
branch
from
749b748 to
c1b68b8
Compare
mischnic
force-pushed
the
mischnic/mdx-sourcetransform
branch
from
c1b68b8 to
8d81b7c
Compare
mischnic
force-pushed
the
mischnic/mdx-sourcetransform
branch
from
8d81b7c to
7945d97
Compare
sokra
approved these changes
Jul 30, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 30, 2024
### Description
Remove `ModuleType::Mdx` and instead handle mdx files using
```rust
ModuleRuleEffect::ModuleType(ModuleType::Typescript {
transforms: ts_app_transforms,
tsx: true,
analyze_types: enable_types,
options: ecmascript_options_vc,
}),
ModuleRuleEffect::SourceTransforms(Vc::cell(vec![Vc::upcast(
MdxTransform::new(mdx_transform_options),
)])),
```
### Testing Instructions
I ran these Next.js tests, which appear to be all mdx related tests
there are
```
mdx with-mdx-rs
app directory
✓ should work in initial html (1262 ms)
✓ should work using browser (1460 ms)
✓ should work in initial html with mdx import (145 ms)
✓ should work using browser with mdx import (1179 ms)
✓ should allow overriding components (1163 ms)
✓ should allow importing client components (26 ms)
✓ should work with next/image (424 ms)
pages directory
✓ should work in initial html (1091 ms)
✓ should work using browser (1216 ms)
✓ should work in initial html with mdx import (147 ms)
✓ should work using browser with mdx import (1202 ms)
✓ should allow overriding components (1236 ms)
```
sokra
pushed a commit
that referenced
this pull request
Jul 31, 2024
Trying #8031 again ~~Depends on #8766 <img width="979" alt="Bildschirmfoto 2024-07-30 um 15 35 48" src="https://github.com/user-attachments/assets/32d88ffc-c816-41fb-928b-79d27e89b56d"> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 31, 2024
* vercel/turborepo#8875 <!-- Tobias Koppers - improve test glob to exclude output folder --> * vercel/turborepo#8874 <!-- Tobias Koppers - only add import references when they are used --> * vercel/turborepo#8766 <!-- Niklas Mischkulnig - Replace MDX ModuleType with MDX SourceTransform --> * vercel/turborepo#8090 <!-- DevMirza - fix(ci): Trying to fix `benchmark-turbopack` workflow --> * vercel/turborepo#8837 <!-- Niklas Mischkulnig - Make JS Lints have lower severity -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 31, 2024
Trying vercel/turborepo#8031 again ~~Depends on vercel/turborepo#8766 <img width="979" alt="Bildschirmfoto 2024-07-30 um 15 35 48" src="https://github.com/user-attachments/assets/32d88ffc-c816-41fb-928b-79d27e89b56d"> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description
Remove `ModuleType::Mdx` and instead handle mdx files using
```rust
ModuleRuleEffect::ModuleType(ModuleType::Typescript {
transforms: ts_app_transforms,
tsx: true,
analyze_types: enable_types,
options: ecmascript_options_vc,
}),
ModuleRuleEffect::SourceTransforms(Vc::cell(vec![Vc::upcast(
MdxTransform::new(mdx_transform_options),
)])),
```
### Testing Instructions
I ran these Next.js tests, which appear to be all mdx related tests
there are
```
mdx with-mdx-rs
app directory
✓ should work in initial html (1262 ms)
✓ should work using browser (1460 ms)
✓ should work in initial html with mdx import (145 ms)
✓ should work using browser with mdx import (1179 ms)
✓ should allow overriding components (1163 ms)
✓ should allow importing client components (26 ms)
✓ should work with next/image (424 ms)
pages directory
✓ should work in initial html (1091 ms)
✓ should work using browser (1216 ms)
✓ should work in initial html with mdx import (147 ms)
✓ should work using browser with mdx import (1202 ms)
✓ should allow overriding components (1236 ms)
```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Trying vercel/turborepo#8031 again ~~Depends on vercel/turborepo#8766 <img width="979" alt="Bildschirmfoto 2024-07-30 um 15 35 48" src="https://github.com/user-attachments/assets/32d88ffc-c816-41fb-928b-79d27e89b56d"> --------- Co-authored-by: 강동윤 (Donny) <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8875 <!-- Tobias Koppers - improve test glob to exclude output folder --> * vercel/turborepo#8874 <!-- Tobias Koppers - only add import references when they are used --> * vercel/turborepo#8766 <!-- Niklas Mischkulnig - Replace MDX ModuleType with MDX SourceTransform --> * vercel/turborepo#8090 <!-- DevMirza - fix(ci): Trying to fix `benchmark-turbopack` workflow --> * vercel/turborepo#8837 <!-- Niklas Mischkulnig - Make JS Lints have lower severity -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
ModuleType::Mdxand instead handle mdx files usingTesting Instructions
I ran these Next.js tests, which appear to be all mdx related tests there are