Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix symlinks and dotfiles while reading glob #8865

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 29, 2024

Description

  • fix dot files handling while reading glob fix symlink handling while reading glob
  • fix symlink handling while reading glob

Testing Instructions

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:34am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:34am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:34am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:34am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:34am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:34am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:34am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:34am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:34am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 0:34am

Copy link
Member Author

sokra commented Jul 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sokra and the rest of your teammates on Graphite Graphite

@sokra sokra changed the title fix dot files handling while reading glob fix symlink handling while reading glob fix symlinks and dotfiles while reading glob Jul 29, 2024
@sokra sokra marked this pull request as ready for review July 29, 2024 12:19
@sokra sokra requested a review from a team as a code owner July 29, 2024 12:19
Copy link
Contributor

github-actions bot commented Jul 29, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jul 29, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Base automatically changed from sokra/resolve-symlink to main July 29, 2024 12:32
fix symlink handling while reading glob
@sokra sokra merged commit f1eb162 into main Jul 29, 2024
54 of 55 checks passed
Copy link
Member Author

sokra commented Jul 29, 2024

Merge activity

@sokra sokra deleted the sokra/glob-dot-file branch July 29, 2024 12:50
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

* fix dot files handling while reading glob fix symlink handling while
reading glob
* fix symlink handling while reading glob

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

* fix dot files handling while reading glob fix symlink handling while
reading glob
* fix symlink handling while reading glob

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

* fix dot files handling while reading glob fix symlink handling while
reading glob
* fix symlink handling while reading glob

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants