refactor: split message sending from creation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technobaboo
force-pushed
the
refactor/messages
branch
2 times, most recently
from
046e492 to
1c2f5f7
Compare
technobaboo
force-pushed
the
refactor/messages
branch
from
0cec7a3 to
461295d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is a bit controversial, but I have had issues where I need to make messages without an easy mutable reference to client and then pass them into the runtime's loop via an mpsc to send it at the client struct's earliest convenience.
This is 1 potential solution to the problem, and honestly I don't believe it's very inconvenient at all. It provides modularity and ease of use after all...