Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format target for source code formatting #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kgugala
Copy link

@kgugala kgugala commented Mar 27, 2019

This PR adds make format target which can be used to autoformat the code in the project. The target uses clang-format-5.0 tool.

@mithro
Copy link

mithro commented Mar 27, 2019

@kgugala Can you link to the output were the code has been formatted?

Could you also add instructions for @kmurray on how to do the formatting after this pull request lands?

@kgugala
Copy link
Author

kgugala commented Mar 27, 2019

the results can be found here: https://github.com/antmicro/libblifparse/tree/run-format
to run the format do:

mkdir build && cd build
cmake ..
make format

@vaughnbetz
Copy link
Contributor

@soheilshahrouz : we should probably turn on format checking for this library too. I didn't notice this stray PR until now. Can you take a look and see if we should merge or update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants