Skip to content

Commit

Permalink
fix compiler warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
soheilshahrouz committed Mar 4, 2024
1 parent fa97eef commit 64336c8
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 11 deletions.
6 changes: 5 additions & 1 deletion vpr/src/noc/bfs_routing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@

BFSRouting::~BFSRouting() = default;

void BFSRouting::route_flow(NocRouterId src_router_id, NocRouterId sink_router_id, NocTrafficFlowId traffic_flow_id, std::vector<NocLinkId>& flow_route, const NocStorage& noc_model) {
void BFSRouting::route_flow(NocRouterId src_router_id,
NocRouterId sink_router_id,
NocTrafficFlowId /*traffic_flow_id*/,
std::vector<NocLinkId>& flow_route,
const NocStorage& noc_model) {
const NocRouter& src_router = noc_model.get_single_noc_router(src_router_id);
const NocRouter& sink_router = noc_model.get_single_noc_router(sink_router_id);

Expand Down
6 changes: 5 additions & 1 deletion vpr/src/noc/bfs_routing.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@ class BFSRouting : public NocRouting {
* @param noc_model A model of the NoC. This is used to traverse the
* NoC and find a route between the two routers.
*/
void route_flow(NocRouterId src_router_id, NocRouterId sink_router_id, NocTrafficFlowId traffic_flow_id, std::vector<NocLinkId>& flow_route, const NocStorage& noc_model) override;
void route_flow(NocRouterId src_router_id,
NocRouterId sink_router_id,
NocTrafficFlowId traffic_flow_id,
std::vector<NocLinkId>& flow_route,
const NocStorage& noc_model) override;

// internally used helper functions
private:
Expand Down
2 changes: 1 addition & 1 deletion vpr/src/noc/negative_first_routing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

NegativeFirstRouting::~NegativeFirstRouting() = default;

const std::vector<TurnModelRouting::Direction>& NegativeFirstRouting::get_legal_directions(NocRouterId src_router_id,
const std::vector<TurnModelRouting::Direction>& NegativeFirstRouting::get_legal_directions(NocRouterId /*src_router_id*/,
NocRouterId curr_router_id,
NocRouterId dst_router_id,
const NocStorage& noc_model) {
Expand Down
2 changes: 1 addition & 1 deletion vpr/src/noc/north_last_routing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

NorthLastRouting::~NorthLastRouting() = default;

const std::vector<TurnModelRouting::Direction>& NorthLastRouting::get_legal_directions(NocRouterId src_router_id,
const std::vector<TurnModelRouting::Direction>& NorthLastRouting::get_legal_directions(NocRouterId /*src_router_id*/,
NocRouterId curr_router_id,
NocRouterId dst_router_id,
const NocStorage& noc_model) {
Expand Down
3 changes: 0 additions & 3 deletions vpr/src/noc/turn_model_routing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ void TurnModelRouting::route_flow(NocRouterId src_router_id,
// the last router added to the path, initialized with the source id
NocRouterId curr_router_id = src_router_id;

// get the physical location of the destination router
const auto dst_loc = dst_router.get_router_physical_location();

/**
* Keeps track of which routers have been reached already
* while traversing the NoC. This variable will help determine
Expand Down
2 changes: 1 addition & 1 deletion vpr/src/noc/west_first_routing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

WestFirstRouting::~WestFirstRouting() = default;

const std::vector<TurnModelRouting::Direction>& WestFirstRouting::get_legal_directions(NocRouterId src_router_id,
const std::vector<TurnModelRouting::Direction>& WestFirstRouting::get_legal_directions(NocRouterId /*src_router_id*/,
NocRouterId curr_router_id,
NocRouterId dst_router_id,
const NocStorage& noc_model) {
Expand Down
6 changes: 3 additions & 3 deletions vpr/src/noc/xy_routing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

XYRouting::~XYRouting() = default;

const std::vector<TurnModelRouting::Direction>& XYRouting::get_legal_directions(NocRouterId src_router_id,
const std::vector<TurnModelRouting::Direction>& XYRouting::get_legal_directions(NocRouterId /*src_router_id*/,
NocRouterId curr_router_id,
NocRouterId dst_router_id,
const NocStorage& noc_model) {
Expand All @@ -31,10 +31,10 @@ const std::vector<TurnModelRouting::Direction>& XYRouting::get_legal_directions(
}

TurnModelRouting::Direction XYRouting::select_next_direction(const std::vector<TurnModelRouting::Direction>& legal_directions,
NocRouterId src_router_id,
NocRouterId /*src_router_id*/,
NocRouterId dst_router_id,
NocRouterId curr_router_id,
NocTrafficFlowId traffic_flow_id,
NocTrafficFlowId /*traffic_flow_id*/,
const NocStorage& noc_model) {
// get current and destination NoC routers
const auto& curr_router = noc_model.get_single_noc_router(curr_router_id);
Expand Down

0 comments on commit 64336c8

Please sign in to comment.