Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for newer tbb lib versions #1961

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

choelzl
Copy link

@choelzl choelzl commented Jan 30, 2022

Intel updated their TBB library, changing the paths and deprecating some features.
In order for VTR to continue working on more modern machines, some adaptation was required.

Description

Intel updated TBB.
To support this, the required changes were:

  • Fix the CMake files to detect either the tbb_stddef.h or version.h files of the library.
  • Fix vpr_api.c due to task_scheduler_init being removed in newer versions
  • Detect the version in CMake (in order to allow backward compatibility)

Related Issue

#1959

Motivation and Context

VTR will not compile on machines with TBB version greater than 2021.1

How Has This Been Tested?

Compiled on a machine with newer TBB version

Types of changes

  • Bug fix (change which fixes an issue)

Checklist:

  • All new and existing tests passed

@github-actions github-actions bot added external_libs VPR VPR FPGA Placement & Routing Tool labels Jan 30, 2022
@vaughnbetz
Copy link
Contributor

@duck2 : can you check if we've already merged in an update to tbb, or if we should merge this?

@choelzl
Copy link
Author

choelzl commented Nov 18, 2022

Something similar has already been done in PR #2166 (dropping support for older versions however).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external_libs VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants