-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Net decomposition: tuning and polishing #2516
Conversation
7fcea0f
to
4e9b58f
Compare
Also add tests for the net decomposing router. One small circuit in strong, so it is checked all the time. Should have a run on bigger designs too in one of the nightly tests. |
Should try to land this before the code format PR if at all possible. Fahri thinks this can be landed in 2 weeks (mid-November) but that it shouldn't block a code format PR. |
69304fe
to
f67a224
Compare
@duck2 : can you add the QoR data as it becomes available? We'll need: net-decomposing router, serial router, master router anyway (your call if you also want to check the baseline router to be safe) |
f67a224
to
40814f8
Compare
QoR for two stage routing:
|
I checked for increased memory usage with flat router. Doesn't seem to be there anymore. Running flat router experiments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing the comments. 2-stage routing results look good. Just need the flat results and we can merge.
Adding @MohamedElgammal. @duck2 : please keep us posted on the flat routing results. If they look good, we can merge. |
We may speculatively merge this and skip waiting for flat router results if you want. It seems to be taking a while. |
@MohamedElgammal : let me know if this is holding you up and I can speculatively merge it. @duck2 : please post updates on how flat routing is looking as you have them. |
Flat router results: (I ran this on my own PC, so the runtime may be noisy)
|
Flat routing (serial) has improved with @duck2 's changes. (Yaay!). Merging this, as Fahri has separately already verified the flat routing parallel works better with this change. |
Paper version of the net decomposing router. Major fixes are: