Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End user documentation for Interactive Path Analysis Tool (VPR server mode) #2560

Merged
merged 62 commits into from
Jun 11, 2024

Conversation

w0lek
Copy link
Contributor

@w0lek w0lek commented May 27, 2024

Description

End user documentation for Interactive Path Analysis Tool (VPR server mode).

Motivation and Context

Allows maintaining and enhancing the Server mode feature for other developers by providing end-user documentation, API documentation, etc.

How Has This Been Tested?

cd doc && make html
reviewing result index.html

Types of changes

  • code formatting change
  • code commenting coverage
  • end user doc

w0lek and others added 30 commits May 7, 2024 16:46
…n doxygen. add some code comment, start filling server.rst
…g& type, int crit_path_num, e_timing_report_detail details_level, bool is_flat_routing);
@AlexandreSinger
Copy link
Contributor

@w0lek Please be aware that every time you push to this branch it is independently calling the CI. So, from this morning alone you have called the CI 10 times which are all running in parallel. I recommend making a set of commits and pushing when you intend on having the code tested and reviewed.

@w0lek
Copy link
Contributor Author

w0lek commented Jun 7, 2024

@w0lek Please be aware that every time you push to this branch it is independently calling the CI. So, from this morning alone you have called the CI 10 times which are all running in parallel. I recommend making a set of commits and pushing when you intend on having the code tested and reviewed.

@AlexandreSinger sorry about that.
I still need push changes with minor steps to sync and execute my local build node, which is setup to build the doc target. My main dev machine cannot do a doc target build(i suspect due to old ubuntu version). So for me pushing minor changes is necessary sometimes.
If i create new dev branch from branch ipa_end_user_doc which doesn't involved in the PR, aggregate my changes there, and merge them at final into ipa_end_user_doc when i done with all changes, will that not trigger CI at each minor commit, right?
I am going to try that, please let me know, if i still flood the CI.

@AlexandreSinger
Copy link
Contributor

@w0lek I completely understand your issue. I have a PR currently waiting to be merged which will resolve this issue: #2589

This PR will cancel previous runs on branches where the CI is called again.

If you were to raise a branch on your own fork and push to that branch it should not call the CI on our side anymore. Thank you for your understanding!

@w0lek w0lek requested a review from vaughnbetz June 10, 2024 20:18
@w0lek
Copy link
Contributor Author

w0lek commented Jun 10, 2024

@vaughnbetz thank you for the review! i have corrected all review tasks.
FYI: i am going to vacation during this week, so if there will be new finding, i will be able to make a corrections on next week only.
FYI2: The Interactive Path Analysis client implementation is under developing, after vacation i will create PR with it. I didn't forget, sorry for delay with that.

@vaughnbetz
Copy link
Contributor

Thanks @w0lek ! Have a great and well-deserved vacation :).

@vaughnbetz vaughnbetz merged commit ef4b778 into verilog-to-routing:master Jun 11, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants