Upgrade CapNProto from v0.9.1 to v1.0.2 #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to upgrade CapNProto to a new version (simply), had to remove the old folder entirely before upgrading to a new version. Due to how the subtree script works, this must be done in its own commit.
git-subtree-dir: libs/EXTERNAL/capnproto git-subtree-split: 1a0e12c0a3ba1f0dbbad45ddfef555166e0a14fc
capnproto: Adding libs/EXTERNAL/capnproto/ as an external git subtree from https://github.com/capnproto/capnproto.git v1.0.2
github-actions
bot
added
VPR
On CI, A CMake deprecation error occurs since CMake version < 3.5 will be removed in a future version of CMake. On the dev branch of CapNProto, they fixed this issue by setting the minimum CMake version to 3.16: capnproto/capnproto@2354ae2 Replicated these changes locally. Hopefully the next time we upgrade CapNProto this will be in the changes.
|
@vaughnbetz This has passed CI. It resolves the deprecation warnings from std::iterator. Relatively basic upgrade with no big road-blocks. This also resolves an issue with the current master. The most recent merged commit did not compile. There was an ambiguous reference to an enum in |
|
Ah, I also just saw and fixed that too :). A lesson to merge for merging PRs that have been around a while without hitting the update button -- was trying to save some CI cycles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2557 for context.
Upgraded the capnproto subtree from v0.9.1 to v1.0.2.