-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify a single location or a specific region for a custom switch block #2664
Conversation
…or different locations within grid
…rilog-to-routing into specify_loc_for_custom_SB
…rilog-to-routing into specify_loc_for_custom_SB
…rilog-to-routing into specify_loc_for_custom_SB
…rilog-to-routing into specify_loc_for_custom_SB
Thanks @saaramahmoudi . I'll review shortly. Can you also please update the documentation and add it to this PR? |
Yes, I will update both documentation and a new CI test for this PR later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saaramahmoudi Can you include the tests that verify this feature in the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to address (mine partially overlap Soheil's).
Also, it would be good to make the documentation update now, as part of this PR as well. That also might help clarify the precise meaning of repeat and increment (as would comments on the structure data members storing the sb_loc information).
@saaramahmoudi I don't see any new files related to testing; is there something that still needs to be added? |
@petergrossmann21 @vaughnbetz I am so sorry, but I have been busy doing a different task at work. I am trying my best to land this PR as soon as possible. It might take two-three weeks. |
@saaramahmoudi : I think this is ready to merge, but I just merged a libcatch2 update that caused a conflict (sorry!). If you fix that conflict I think this is good to go. |
@vaughnbetz |
QoR looks good, thanks. |
@vaughnbetz This branch is also ready to merge |
Thanks @saaramahmoudi ! |
This PR generalize the custom switch block description to allow the user to specify a exact (x,y) location for the switch block by setting type="XY_SPECIFIED", the exact syntax is explained below:
How Has This Been Tested?
The x and y attribute is tested by @petergrossmann21, and the region description is tested by myself.
Types of changes
Checklist:
I will add a new test and update documentation later today, but I have created the PR to start the review process.