Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bounds check for forced primitive site #2671

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

KA7E
Copy link
Contributor

@KA7E KA7E commented Jul 31, 2024

When seeking a primitive site matching a user-specified site index, verify that the index is within the available range for the primitive type within the current physical block type.

Description

Added a bounds check and error message.

Related Issue

Motivation and Context

A error message that alerts the user to out of bounds indices helps to identify indexing errors in externally generated flat placements. For example, ISPD placement tools use different indexing for LUTs than is required by the legalizer.

How Has This Been Tested?

Tested by legalizing ISPD placements with and without out of bounds site indices.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@KA7E KA7E requested a review from vaughnbetz July 31, 2024 15:52
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Jul 31, 2024
@vaughnbetz vaughnbetz merged commit b2cf268 into master Aug 1, 2024
53 checks passed
@vaughnbetz vaughnbetz deleted the force_site_bounds_check branch August 1, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants