Placer class #2813
Merged
Placer class #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
soheilshahrouz
commented
Nov 20, 2024
| /* Allocated here because it goes into timing critical code where each memory allocation is expensive */ | ||
| IntraLbPbPinLookup pb_gpin_lookup(device_ctx.logical_block_types); | ||
| //Enables fast look-up of atom pins connect to CLB pins | ||
| ClusteredPinAtomPinsLookup netlist_pin_lookup(cluster_ctx.clb_nlist, atom_ctx.nlist, pb_gpin_lookup); |
There was a problem hiding this comment.
@vaughnbetz
pb_gpin_lookup and netlist_pin_lookup are initialized after the placement timer starts in line 215. Is their initialization times intentionally included in the total placement time?
There was a problem hiding this comment.
Probably just what was convenient. They can be moved outside placement if it cleans up the code, but please measure how long they take and if it can be significant they should get their own timers (either on their own or together).
|
titan_quick_qor
|
There was a problem hiding this comment.
Hi @soheilshahrouz these changes look great to me! I left some minor comments. I am excited to see this PR merged!
…once in header files
vaughnbetz
reviewed
Nov 25, 2024
…ties and NetPinTimingInvalidator
|
@vaughnbetz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Placerclass that encapsulates all objects and variable that are placement instance specific. Shared objects like delay model are still constructed outside this class and shared across allPlacerinstances.Don't look at the code yet; it's a mess! :)