-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Packer] Created GreedyClusterer Class #2816
[Packer] Created GreedyClusterer Class #2816
Conversation
Began encapsulating the different parts of the packer into classes. This will help organize the packer better, which will make it easier to modify in the future. My plan is to clean up the different parts of the packer so I can add flat placement information into the gain calculation so it can be integrated into the AP flow.
e77d55d
to
96322ff
Compare
@vaughnbetz After looking into the greedy clusterer more, I realized that creating my own AP clusterer would cause me to reinvent the wheel a lot. It will be much easier (and probably more useful for the VTR ecosystem) if I clean up the Packer to make it easier to add the ability to optionally pass a flat placement into the clusterer. This PR starts the process of cleaning things up by creating a GreedyClusterer class. I plan to move some of the functions from cluster_utils.cpp into this class and continue to clean up dead / confusing code. I wanted to merge this in pieces to make it easier to review. Let me know what you think! |
That seems reasonable to me. I think the current clusterer has 3 limitations / trrade-offs:
|
@vaughnbetz Sounds good! I have some ideas on how we can upgrade the packer with flat placement information. We can discuss in our next one on one. Do you have any comments on this PR? I have another PR almost ready which abstracts the seed selection logic into a class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; some commenting suggestions.
Updated comments based on Vaughn's feedback.
Began encapsulating the different parts of the packer into classes. This will help organize the packer better, which will make it easier to modify in the future.
My plan is to clean up the different parts of the packer so I can add flat placement information into the gain calculation so it can be integrated into the AP flow.