Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Added GCC-13 on Ubuntu Noble as a Compatibility Test #2834

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlexandreSinger
Copy link
Contributor

Now that the GCC-13 build on Ubuntu Noble is warning clean, adding it to the CI to maintain it. This is a stepping stone to moving the entire CI to Ubuntu Noble.

Now that the GCC-13 build on Ubuntu Noble is warning clean, adding it to
the CI to maintain it. This is a stepping stone to moving the entire CI
to Ubuntu Noble.
@github-actions github-actions bot added the infra Project Infrastructure label Dec 3, 2024
@vaughnbetz
Copy link
Contributor

@w0lek : It looks like this warning needs to be fixed so we can move to Ubuntu 24.04 and be warning clean.

[ 71%] Building CXX object libs/EXTERNAL/sockpp/src/CMakeFiles/sockpp-objs.dir/unix/unix_address.cpp.o
/home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/libs/EXTERNAL/sockpp/src/unix/unix_address.cpp: In constructor ‘sockpp::unix_address::unix_address(const std::string&)’:
/home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/libs/EXTERNAL/sockpp/src/unix/unix_address.cpp:55:18: error: ‘char* _builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 108 equals destination size [-Werror=stringop-truncation]
55 | ::strncpy(addr
.sun_path, path.c_str(), MAX_PATH_NAME);
| ^
cc1plus: all warnings being treated as errors

@w0lek
Copy link
Contributor

w0lek commented Dec 17, 2024

@w0lek : It looks like this warning needs to be fixed so we can move to Ubuntu 24.04 and be warning clean.

[ 71%] Building CXX object libs/EXTERNAL/sockpp/src/CMakeFiles/sockpp-objs.dir/unix/unix_address.cpp.o /home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/libs/EXTERNAL/sockpp/src/unix/unix_address.cpp: In constructor ‘sockpp::unix_address::unix_address(const std::string&)’: /home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/libs/EXTERNAL/sockpp/src/unix/unix_address.cpp:55:18: error: ‘char* _builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 108 equals destination size [-Werror=stringop-truncation] 55 | ::strncpy(addr.sun_path, path.c_str(), MAX_PATH_NAME); | ^ cc1plus: all warnings being treated as errors

Thank you. I created PR #2845
with a fix. I don't have ubuntu 24.04 locally to check, so i am going to wait CI result in #2845

Updated the sockpp submodule to resolve a warning in the Noble build.
@AlexandreSinger
Copy link
Contributor Author

@w0lek That fixed the warning! Thank you! The GCC13 test is only on this PR, so I pulled your changes into this PR. They passed the test. The test is still failing due to another (unrelated) warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external_libs infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants