Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update koios tasks and add a koios_task_list that runs all koios benchmarks #2838

Closed
wants to merge 1 commit into from

Conversation

MohamedElgammal
Copy link
Contributor

With this update PR, running the koios_task_list.txt will run 37 Koios benchmarks

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohamedElgammal . Does the documentation need and update with this? Currently I believe it has instructions on running various Koios sub-suites -- can we now just say they should run and parse this one (and give the commands for that)?

script_params=-track_memory_usage -crit_path_router_iterations 100 --route_chan_width 400 --target_utilization 0.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for the .12 target_utilization? We should at least comment it (and it is quite a bit lower than the old .28).

@vaughnbetz
Copy link
Contributor

@vaughnbetz
Copy link
Contributor

Nag, nag ...

@MohamedElgammal
Copy link
Contributor Author

@vaughnbetz I think this PR is no longer needed. I have opened a new PR that includes all the changes from v9.0 branch (PR #2866 )

@vaughnbetz
Copy link
Contributor

@MohamedElgammal : What runs do we recommend people run / extract when checking QoR on the Koios designs? The first four configs (the ones with hard blocks)? I think we should mention that somewhere in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants