Simple Place Delay Model Read/Write #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
vaughnbetz
requested changes
Dec 16, 2024
| void write(const std::string& /*file*/) const override {} | ||
| void read(const std::string& /*file*/) override; | ||
| void write(const std::string& /*file*/) const override; | ||
| const vtr::NdMatrix<float, 5>& delays() const { |
There was a problem hiding this comment.
Any reasonable n why this is always a template parameter of 5 rather than a passed one n template parameter?
There was a problem hiding this comment.
Doxygen comment would be good.
There was a problem hiding this comment.
The underlying array that stores the delay is a 5D array, and its dimension size remains constant across all instances of this class. So, I don’t think we need to pass a template parameter for it.
vaughnbetz
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the read/write functionality for the simple placement delay model. The feature was tested on the Titan
murax_stratixiv_arch_timingcircuit, and the resulting placement was consistent with the placement delay model read from the previously written file.Related Issue
This PR addresses Issue #2840