Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing import #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add missing import #7

wants to merge 1 commit into from

Conversation

txbm
Copy link

@txbm txbm commented Oct 17, 2016

The ClientError exception was missing from the imports in MessageSerializer. Judging from the comments in the implementation of the client.get_by_id method I'm guessing the test cases missed it because the MockSchemaRegistryClient does not have a stub that would throw the exception because it's not expected happen. It does happen in certain circumstances though and that's how I discovered the missing import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant