-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Nushell support #389
Conversation
Implements #207
Will release 0.7.0 later today |
Thanks for reviewing this, @bytemain. Did you have any ideas as to why vfox didn't seem to be working for me in Nushell even with these changes, as I mentioned in my pull request summary above? Were you able to test it out on your machine? |
First of all, I'd like to apologize. I didn't carefully review this PR that morning. I thought the function had already been implemented. |
The overall idea is on the right track. but the |
fixed in #397 |
Implements #207
Though this implementation includes everything that needs done according to my understanding, it still doesn't seem to be working completely. I'd appreciate some help in figuring out what I might be missing. I believe the environment variables that are passed in to
Export
are being set correctly in thepre_prompt
hook, but I'm not getting the expected SDKs and versions when I try to run them.Also, note that this implementation wasn't quite as straightforward as I'd hoped, because Nushell doesn't have
eval
-like functionality. See https://www.nushell.sh/book/how_nushell_code_gets_run.html for more details, and see my comments below that point out how this impacts the implementation.