address PR comments

vertica · Oct 22, 2024 · 4f3ec86 · 4f3ec86
1 parent 61de288
commit 4f3ec86
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 21 deletions.
diff --git a/packages/vertica-nodejs/lib/connection.js b/packages/vertica-nodejs/lib/connection.js
@@ -48,8 +48,8 @@ class Connection extends EventEmitter {
 
     if (this.tls_config === undefined) {
       this.tls_mode = config.tls_mode || 'prefer'
-      this.tls_client_key = config.tls_client_key
-      this.tls_client_cert = config.tls_client_cert
+      // this.tls_client_key = config.tls_client_key
+      // this.tls_client_cert = config.tls_client_cert
       this.tls_trusted_certs = config.tls_trusted_certs
       this.tls_host = config.tls_host
     }
@@ -154,24 +154,6 @@ class Connection extends EventEmitter {
             return self.emit('error', err)
           }
         }
-        // else if (self.tls_mode === 'prefer') { // basic TLS connection, does not verify CA certificate
-        //   tls_options.rejectUnauthorized = false
-        //   tls_options.checkServerIdentity = (host , cert) => undefined
-        //   if (self.tls_trusted_certs) {
-        //     tls_options.ca = fs.readFileSync(self.tls_trusted_certs).toString()
-        //   }
-        //   /*if (self.tls_client_cert) {// the client won't know whether or not this is required, depends on server mode
-        //     tls_options.cert = fs.readFileSync(self.tls_client_cert).toString()
-        //   }
-        //   if (self.tls_client_key) {
-        //     tls_options.key = fs.readFileSync(self.tls_client_key).toString()
-        //   }*/
-        //   try {
-        //     self.stream = tls.connect(tls_options);
-        //   } catch (err) {
-        //     return self.emit('error', err)
-        //   }
-        // }
         else if (self.tls_mode === 'verify-ca') { //verify that the server certificate is signed by a trusted CA
           try {
             tls_options.rejectUnauthorized = true

diff --git a/packages/vertica-nodejs/test/unit/connection/inbound-parser-tests.js b/packages/vertica-nodejs/test/unit/connection/inbound-parser-tests.js
@@ -9,7 +9,6 @@ require('./test-helper')
 const BufferList = require('../../buffer-list')
 var Connection = require('../../../lib/connection')
 var buffers = require('../../test-buffers')
-const { tls_mode } = require('../../../lib/defaults')
 var PARSE = function (buffer) {
   return new Parser(buffer).parse()
 }