加了一个自定义apikey的功能 #40
Open
加了一个自定义apikey的功能 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
原作者是不是停止维护这个项目了。。我也想加个这样的功能来着。 |
Qbuer
reviewed
Dec 29, 2016
|
|
||
| function getbasicurl(useHttps) { | ||
| var thisurl = (useHttps ? urls.dictHttps : urls.dict); | ||
| var chazduserkey = localStorage.getItem("chazduserkey"); |
There was a problem hiding this comment.
我感觉没啥必要，而且用chrome.sync是异步调用，现在写的这个逻辑不能用
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在popup页面加了两个输入框，分别存入key和keyfrom，之后便能用自定义的api key来请求了