Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure the upgrade uses the pause image #131

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

mpiscaer
Copy link
Contributor

When doing a k8s upgrade in a isolated env, kubelet role has a requirement to the containerd role.

This containerd role generates a config file. In this config file it has a config setting where to find the sandbox image.

When doing a k8s upgrade in a isolated env, kubelet role has a requirement to the containerd role.

This containerd role generates a config file. In this config file it has a config setting where to find the sandbox image.
Copy link
Member

@okozachenko1203 okozachenko1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpiscaer could you differentiate the commands when we use atmosphere and not? here is the example.

https://github.com/vexxhost/ansible-collection-kubernetes/blob/main/docs/ops/upgrades.md#control-plane-infrastructure--containerd

@mpiscaer
Copy link
Contributor Author

@okozachenko1203 I did a commit where I added a playbook tab. I wasn't sure if you meant it like this?

@okozachenko1203
Copy link
Member

@okozachenko1203 I did a commit where I added a playbook tab. I wasn't sure if you meant it like this?

yes, exactly.
just one nit, could you add the indents as Control plane infrastructure + containerd section?

@mpiscaer
Copy link
Contributor Author

@okozachenko1203 Thanks for you feedback

@okozachenko1203 okozachenko1203 merged commit 7ca794c into vexxhost:main Sep 19, 2024
84 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants