Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts to fix set_species causing full heals #36706

Merged

Conversation

boy2mantwicethefam
Copy link
Contributor

@boy2mantwicethefam boy2mantwicethefam commented Jun 19, 2024

Added new code that transfers damage from before the mob had its limbs reset to after. The damage style tries to remember the previous damage the mob sustained and in what limbs, but it's not perfect; it only applies from human-to-human transformations, meaning that going from a human to a borg and back to a human will reset the damages.

Should work for Staff of Change, species-changing diseases, the Dissolve genetic power, species changes caused by the cursed dice, ghoulification, cursed mirrors, Nosferatu vampire transformations, the Synthskeleton chemical, and the "Randomized" chemical.

Also fixed a bug where mindless mobs couldn't be transformed from cyborgs, AIs and MoMMIs.

Fixed the limb damage code so that damage overflow to other limbs now works better.

Fixed take_overall_damage dealing far more damage than intended when transferring damage values; it not only had a damage multiplier code of its own that stacked with the limb damage's damage multiplier (meaning that dionae could take as much as 6x damage from burn) but it didn't consider the damage overflow of the limb that it targeted, increasing the amount of damage dealt. Now it will prevent the limb from dealing overflowing damage while it focuses on dishing out the damage itself.

Internal wounds will no longer be considered for the purposes of total damage. In gameplay terms this means that internal wounds don't cause a sudden 15 damage dealt whenever they happen anymore.

And yes, Nosferatu can probably be added back with this change.

🆑

  • bugfix: Mindless cyborgs, AIs and MoMMIs can now be properly transformed.
  • bugfix: Fixed a bug where a piece of code responsible for generalized damaged dealing could, in some cases (mostly regarding species resistances and weaknesses to damage types) do far more damage than intended.
  • tweak: Internal wounds will no longer be considered sources of damage to determine limb damage.
  • experiment: Attempted a fix where humans transformed into other humans through means such as the Staff of Change will now properly transfer their damage over instead of being completely healed.

@SonixApache
Copy link
Contributor

why randomize the damage though

@boy2mantwicethefam
Copy link
Contributor Author

It's the most straightforward way, but I'll probably work on the PR more to re-implement the overengineered method of limb-to-limb damage.

@jwhitak jwhitak added Bug / Fix This is either a bug or a fix for a bug. Balance Potentially going to upset people as it changes balance of the game. labels Jun 25, 2024
@west3436 west3436 merged commit 717e3ea into vgstation-coders:Bleeding-Edge Jul 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Potentially going to upset people as it changes balance of the game. Bug / Fix This is either a bug or a fix for a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants