Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaNshot shells #37260

Open
wants to merge 20 commits into
base: Bleeding-Edge
Choose a base branch
from

Conversation

SECBATON-GRIFFON
Copy link
Contributor

@SECBATON-GRIFFON SECBATON-GRIFFON commented Oct 11, 2024

[content]

What this does

adds a fun new kind of shotgun shells to the contraband section of ammolathes
FaNshots do the same damage as beanbags, but knock back targets up to 7 tiles depending on distance from the firer, with that being the range at point blank. Syndies can purchase a high force version of these for 12TC (8TC discounted for wardens and HoS) which do 30 damage and double knockback.

Why it's good

fun kind of knockback ammo traded off for damage

How it was tested

purchasing from ammolathe and uplink, firing it at things

Changelog

🆑

  • rscadd: Contraband hacked ammolathes now stock FaNshot shells, a type of shotgun shell known for their knockback force in exchange for being as damaging as a beanbag shell. Syndicate members can purchase a beanbag-disguised high force varieties of these for 12TC (8TC warden and HoS discount) that do 30 damage and double the knockback power.

@D3athrow-Issues D3athrow-Issues added the Content Adds something. Neat! label Oct 11, 2024
@boy2mantwicethefam
Copy link
Contributor

"knock objects from their anchor" uh oh

@SECBATON-GRIFFON
Copy link
Contributor Author

"knock objects from their anchor" uh oh

if there's any sanity checks i missed then lay them on me

@boy2mantwicethefam
Copy link
Contributor

There's a number of things that base themselves around being anchored such as the singularity and wall-mounted items, overall it affecting unanchored things might introduce too much jank and I recommend just leaving it to pushing around unanchored objects at most.

@SECBATON-GRIFFON
Copy link
Contributor Author

There's a number of things that base themselves around being anchored such as the singularity and wall-mounted items, overall it affecting unanchored things might introduce too much jank and I recommend just leaving it to pushing around unanchored objects at most.

yea, wall mounted items are being very strange on testing, currently working thru them

@CrazyAmphibian
Copy link
Contributor

nice hustle tons-a-fun, next time eat a salad

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review October 11, 2024 21:04
@angryturnip
Copy link
Contributor

I want this in the code for me to use for bussing, but I feel it'd introduce too much jank as is to give players access to freely

@SECBATON-GRIFFON
Copy link
Contributor Author

SECBATON-GRIFFON commented Oct 11, 2024

I want this in the code for me to use for bussing, but I feel it'd introduce too much jank as is to give players access to freely

would it be less jank if i restricted the unanchoring to machines with the WRENCHMOVE flag? did that now

@CrazyAmphibian
Copy link
Contributor

CrazyAmphibian commented Oct 11, 2024

i feel like it unanchoring things is a bit much, not to mention all the weird edge cases

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as draft October 11, 2024 21:30
@SonixApache
Copy link
Contributor

remove from ammolathe, add to crate of weird shotgun shells for vox traders

@SECBATON-GRIFFON
Copy link
Contributor Author

remove from ammolathe, add to crate of weird shotgun shells for vox traders

if that's a thing already i wouldn't mind doing it

@jwhitak
Copy link
Collaborator

jwhitak commented Oct 11, 2024

Collabs talked, we're not fans of the unlocking ability. Too many edge cases. It's gotta go, I'm sorry.

Tampering this bullet straight buffs it. This doesn't even fit the nature of tampering imo, which imposes a strange drawback on the user. A good tamper for this bullet would be having it knock back the shooter instead of firing a bullet (though this would be considerably harder to code).

For transparency: I'm personally not a fan of arcane tamper right now. It's getting beyond emag levels of power creeped, and becoming more and more dangerous with each new buff. Compare the utility of it to something like summon snacks. Folks are already asking me to PR a three to five minute expiration on tampered objects.

Otherwise I don't have many problems with a bullet that gives heavy knockback in the ammolathe. Would be fitting as an exotic trader shell too.

@SECBATON-GRIFFON
Copy link
Contributor Author

SECBATON-GRIFFON commented Oct 11, 2024

Collabs talked, we're not fans of the unlocking ability. Too many edge cases. It's gotta go, I'm sorry.

the anchoring thing? fine i guess

Tampering this bullet straight buffs it. This doesn't even fit the nature of tampering imo, which imposes a strange drawback on the user. A good tamper for this bullet would be having it knock back the shooter instead of firing a bullet (though this would be considerably harder to code).

For transparency: I'm personally not a fan of arcane tamper right now. It's getting beyond emag levels of power creeped, and becoming more and more dangerous with each new buff. Compare the utility of it to something like summon snacks. Folks are already asking me to PR a three to five minute expiration on tampered objects.

yea i added this before i saw your feedback on it, i'll remove it since it's rare anyways. plus you can go ahead and PR that honestly

@SECBATON-GRIFFON SECBATON-GRIFFON marked this pull request as ready for review October 11, 2024 23:08
@Eneocho
Copy link
Collaborator

Eneocho commented Oct 12, 2024

you damn better make it so shooting the FANshot whilst jumping knocks you back, as well as the victim

@west3436 west3436 requested a review from jwhitak October 14, 2024 12:40
@Blithering
Copy link
Contributor

Please could you add barman to the discount list? He's the only crewman to have a shotgun in his default kit and his existing special shells are awful (makes you act drunk if you have lots of booze in your system?)

@SECBATON-GRIFFON
Copy link
Contributor Author

Please could you add barman to the discount list? He's the only crewman to have a shotgun in his default kit and his existing special shells are awful (makes you act drunk if you have lots of booze in your system?)

deal

@githubuser4141
Copy link
Contributor

Sad the unachoring was removed, we could've had a firing squad singularity containment setup.

@Loafin34
Copy link

could you call these something relating to physics, like maybe "Inertia shells" or something?

@SECBATON-GRIFFON
Copy link
Contributor Author

could you call these something relating to physics, like maybe "Inertia shells" or something?

don't mind this since i like it more, plis emoji this comment if you like this name peeople

@Loafin34
Copy link

oh wait force of nature shot thats way better

@SECBATON-GRIFFON
Copy link
Contributor Author

oh wait force of nature shot thats way better

in retrospect not the best name but at least "fanshot" is a subtle nod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat!
Projects
None yet
Development

Successfully merging this pull request may close these issues.