Skip to content

Commit

Permalink
Merge pull request #4400 from vgteam/path-normalize
Browse files Browse the repository at this point in the history
Set snarl distance to 0 in path normalizer now that distance index is fixed.
  • Loading branch information
adamnovak authored Sep 26, 2024
2 parents 62ef06c + 1a9fd57 commit d734852
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions src/traversal_clusters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,7 @@ void merge_equivalent_traversals_in_graph(MutablePathHandleGraph* graph, const u
SnarlDistanceIndex distance_index;
{
IntegratedSnarlFinder snarl_finder(*graph);
// todo: why can't I pass in 0 below -- I don't want any dinstances!
fill_in_distance_index(&distance_index, graph, &snarl_finder, 1);
fill_in_distance_index(&distance_index, graph, &snarl_finder, 0);
}

// only consider embedded paths that span snarl
Expand Down
8 changes: 4 additions & 4 deletions test/t/11_vg_paths.t
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ diff original.fa norm_x4.fa
is $? 0 "path normalizer doesnt alter path sequences"

# note: x3 is x4 in reverse, so we key on that
grep x3 norm_x2.gfa | awk '{print $3}' > x4.path
grep x3 norm_x2.gfa | awk '{print $3}' >> x4.path
grep x3 norm_x2.gfa | awk '{print $3}'> x4.norm.path
grep x5 norm_x2.gfa | awk '{print $3}' >> x4.norm.path
grep x3 norm_x4.gfa | awk '{print $3}' > x4.path
grep x3 norm_x4.gfa | awk '{print $3}' >> x4.path
grep x3 norm_x4.gfa | awk '{print $3}'> x4.norm.path
grep x5 norm_x4.gfa | awk '{print $3}' >> x4.norm.path
diff x4.path x4.norm.path
is $? 0 "path normalizere correctly snapped all equivalent paths to x4"

Expand Down

1 comment on commit d734852

@adamnovak
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vg CI tests complete for merge to master. View the full report here.

16 tests passed, 0 tests failed and 0 tests skipped in 17238 seconds

Please sign in to comment.