RSDK-7531 - Add GetProperties to vision service #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
approved these changes
May 8, 2024
Comment on lines
180
to
182
| bool classifications_supported = 1; | ||
| bool detections_supported = 2; | ||
| bool object_point_clouds_supported = 3; |
There was a problem hiding this comment.
Would be nice to have docstrings here, even though the docstrings would be super self explanatory. It's just very useful with auto-generated documentation in the SDKs
|
I see that in some places, the protoc version gets downgraded to a previous version. Can you make sure your local setup is up to date ('make setup' on your api repo) and that you are basing your commit on top of the latest commit of the api repo, too? |
|
Okay great catch on the versioning thing. It's fixed now, I had to nuke my old /opt folder before the make setup. |
bhaney
approved these changes
May 9, 2024
kharijarrett
added
the
ready-for-protos
kharijarrett
removed
the
ready-for-protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file worth viewing here (to see the changes) is the vision.proto . Adding this as scoped here (https://docs.google.com/document/d/1P0eFy1Y5zBT91oFxz32isku3l5HJUHfdzSKYuS-MFMI/edit?usp=sharing)
Everything else is autogenerated.