Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup script #604

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove setup script #604

merged 1 commit into from
Dec 11, 2024

Conversation

benjirewis
Copy link
Member

No description provided.

@github-actions github-actions bot added the safe to test committer is a member of this org label Dec 10, 2024
Otterverse
Otterverse approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the setup from RDK is sufficient and so the remaining makefile targets still work.

@benjirewis benjirewis added the ready-for-protos add this when you want protos to compile on every commit label Dec 11, 2024
@benjirewis benjirewis removed the ready-for-protos add this when you want protos to compile on every commit label Dec 11, 2024
@benjirewis benjirewis added ready-for-protos add this when you want protos to compile on every commit and removed ready-for-protos add this when you want protos to compile on every commit labels Dec 11, 2024
@abe-winter abe-winter removed the safe to test committer is a member of this org label Dec 11, 2024
@benjirewis benjirewis merged commit 9493f42 into viamrobotics:main Dec 11, 2024
10 of 12 checks passed
@benjirewis benjirewis deleted the remove-setup-script branch December 11, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Otterverse Otterverse Otterverse approved these changes

@abe-winter abe-winter Awaiting requested review from abe-winter

Assignees
No one assigned
Labels
protos-compiled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjirewis @Otterverse @abe-winter