Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-3488 Add logging to callAnswererTooBusy warning. #226

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

vijayvuyyuru
Copy link
Member

Hey yall, this PR is just to add more logging to the warning when we get the all answerers are too busy case in goutils. Once this is approved, Ill bump the version in app and put up another PR for that. Thank you!

@viambot viambot added the safe to test Mark as safe to test label Dec 20, 2023
Copy link
Member

@abe-winter abe-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding len(answerChans)

ideally also information about the answerers, but I'm not sure where to get that or what it would look like

@viambot viambot added safe to test Mark as safe to test and removed safe to test Mark as safe to test labels Dec 20, 2023
Copy link
Member

@ohEmily ohEmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great ideas

@vijayvuyyuru vijayvuyyuru merged commit 25a24ec into viamrobotics:main Dec 20, 2023
5 checks passed
@vijayvuyyuru vijayvuyyuru deleted the APP-3488 branch December 20, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Mark as safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants