-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New table component (design guide) #622
base: main
Are you sure you want to change the base?
Conversation
following up from my comment in design sync-- I don't love truncating columns at a max-width as the max state because it means we could be cutting off information without giving the user a way to access it, which seems potentially really frustrating. IMO a better approach is using horizontal scroll for the entire table. This seems like the standard established approach for table design. Horizontally scrolling tables can definitely be really annoying to use, but I think there are other things we can do as follow-ups to make wide/dense data tables more user-friendly, such as...
Including some examples of horizontal scroll for wide tables in practice, as requested in design sync:
(btw, this shouldn't be blocking your PR or anything, Joyce. just sharing my thoughts here as requested in today's sync so we can discuss as a team eventually!) |
+1 on doing horizontal scroll for tables 👍 there's no perfect solution but this is one that is common and robust |
Ticket:
https://viam.atlassian.net/browse/APP-6953
Desire for a table "component", even if only mostly for layout.
Context
<ul />
instead of<table >
due to problems when embedding HTML in table cells (less hidden behavior in HTML elements itself, simpler default CSS with accessibility)theme.ts
is only used for extending Tailwind's default theme settings and not to handle custom CSS class definitions.plugins.ts
is modified to add the table-related classes to ensure these styles are applied globally and available for scalabilityonSorted
hook for sortable tablesNEXT TO DO: Add a design guide to design.viam.com (APP-7487)