fix MongoDB CRUD not throwing on error #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should at least have a one-liner added to the "insert-remove-aggregate" test for the positive case (checking if |
|
yes I will add tests later (in ~4h) |
it's only used in legacy APIs
WebFreak001
force-pushed
the
fix-crud-erroring
branch
from
93cd342 to
d53bcbb
Compare
|
test added |
s-ludwig
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. index constraints failing wasn't throwing any exceptions anymore - now throws a sub-class of MongoException (not MongoDBException)