Fix deserialization of string based enum types #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
force-pushed
the
fix_string_enum_deserialization
branch
from
2a06bff to
fecff7d
Compare
l-kramer
approved these changes
Feb 7, 2024
This is using and extending the unit tests by @madmax-inc in #2345 and replicates the manual value-to-enum conversion with an added `NoDuplicates` to fix handling of enums with duplicate values. Fixes #2209.
s-ludwig
force-pushed
the
fix_string_enum_deserialization
branch
from
fecff7d to
3227f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the original PR unfortunately got stuck, this is using and extending the unit tests by @madmax-inc in #2345 and replicates the manual value-to-enum conversion with an added
NoDuplicatesto fix handling of enums with duplicate values.Fixes #2209. Closes #2345.