Fix a few scope related deprecation warnings #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
reviewed
Feb 10, 2024
http/vibe/http/common.d
Outdated
| @@ -300,7 +300,7 @@ class HTTPResponse { | |||
| InetHeaderMap headers; | |||
|
|
|||
| /// All cookies that shall be set on the client for this request | |||
| @property ref DictionaryList!Cookie cookies() { return m_cookies; } | |||
| @property scope ref DictionaryList!Cookie cookies() return { return m_cookies; } | |||
There was a problem hiding this comment.
Suggested change
| @property scope ref DictionaryList!Cookie cookies() return { return m_cookies; } | |
| @property ref DictionaryList!Cookie cookies() scope return { return m_cookies; } |
?
There was a problem hiding this comment.
Do we even need the scope at all here? I still couldn't force myself to look through the spec to fully grasp the scope additions (assuming that everything is correctly documented by now) and from the observed effects I'm unsure whether return a) implies scope, b) is required to be used in conjunction with scope, or c) has an independent effect on the parameter/this pointer.
There was a problem hiding this comment.
We need scope only if we intend to call this function with a scope DictionaryList!Cookie is my understanding. But I have a similar issue with the spec.
Geod24
reviewed
Feb 10, 2024
Geod24
approved these changes
Feb 10, 2024
s-ludwig
force-pushed
the
scope_deprecation_fixes
branch
from
b5cc51f to
b1a6292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.