Final #17

vic778 · 2022-06-03T12:59:29Z

This API contains :

create the user controller that contains the action for creating a user and updating the user profile
create the user model and make validations
create the RSpec folder and config factory
fix cross error by added cors access
add rubocop to fix all linter error
Add login method
Add route to login
Change the route for login
Remove the question mark i=for the authorize action
Add the validations
Create the route for scooters
Add year color and model to scooter tables
Add the association
Create the test for scooters
Create the migration
Create controllers for reservations
Update scooters with availability and finish controller methods
Add routes for reservation
Add serializer
Create a controller for reservations
Describe the project

Note: Click here for the frontend PR

…ed bt bcrypt

Register

Sign in

*Total -- 2,192.68kb -> 1,885.65kb (14%) /public/uploads/motorcycle/image/3/Screenshot_from_2022-05-16_20-24-02.png -- 251.87kb -> 205.93kb (18.24%) /public/uploads/motorcycle/image/1/Screenshot_from_2022-05-16_20-24-02.png -- 251.87kb -> 205.93kb (18.24%) /public/uploads/motorcycle/image/2/Screenshot_from_2022-05-16_20-24-02.png -- 251.87kb -> 205.93kb (18.24%) /public/uploads/motorcycle/image/2/Screenshot_from_2022-05-15_18-02-26.png -- 500.88kb -> 439.65kb (12.22%) /public/uploads/tmp/1652706439-434801145931843-0006-4248/Screenshot_from_2022-05-15_18-02-26.png -- 500.88kb -> 439.65kb (12.22%) /public/uploads/motorcycle/image/2/default_Screenshot_from_2022-05-15_18-02-26.png -- 90.78kb -> 79.81kb (12.08%) /public/uploads/tmp/1652706439-434801145931843-0006-4248/default_Screenshot_from_2022-05-15_18-02-26.png -- 90.78kb -> 79.81kb (12.08%) /public/uploads/motorcycle/image/2/default_Screenshot_from_2022-05-16_20-24-02.png -- 62.85kb -> 55.44kb (11.8%) /public/uploads/motorcycle/image/3/default_Screenshot_from_2022-05-16_20-24-02.png -- 62.85kb -> 55.44kb (11.8%) /public/uploads/motorcycle/image/1/default_Screenshot_from_2022-05-16_20-24-02.png -- 62.85kb -> 55.44kb (11.8%) /public/uploads/tmp/1652706439-434801145931843-0006-4248/thumb_Screenshot_from_2022-05-15_18-02-26.png -- 2.21kb -> 2.00kb (9.54%) /public/uploads/motorcycle/image/2/thumb_Screenshot_from_2022-05-15_18-02-26.png -- 2.21kb -> 2.00kb (9.54%) /public/uploads/motorcycle/image/2/thumb_Screenshot_from_2022-05-16_20-24-02.png -- 1.77kb -> 1.62kb (8.53%) /public/uploads/motorcycle/image/1/thumb_Screenshot_from_2022-05-16_20-24-02.png -- 1.77kb -> 1.62kb (8.53%) /public/uploads/motorcycle/image/3/thumb_Screenshot_from_2022-05-16_20-24-02.png -- 1.77kb -> 1.62kb (8.53%) /public/uploads/motorcycle/image/1/default_3.jpg -- 12.04kb -> 11.49kb (4.61%) /public/uploads/motorcycle/image/1/default_1.jpg -- 21.72kb -> 21.13kb (2.72%) /public/uploads/tmp/1652784708-545125553834720-0001-7998/default_1.jpg -- 21.72kb -> 21.13kb (2.72%) Signed-off-by: ImgBotApp <[email protected]>

[ImgBot] Optimize images

mosesogwo

Hi team,

Good job so far!
There are some issues to be handled that will make your project superb.

Highlights

Good job with restful controller actions and keeping best practices.

Suggested Changes ♻️

Revert changes made to the linter config.
Make sure that tests are passing.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mosesogwo · 2022-06-03T20:39:13Z

README.md

+
+## Acknowledgments
+
+- Hat tip to anyone whose code was used !


It's better to acknowledge a particular person or material that was helpful in building the project

mosesogwo · 2022-06-03T20:40:38Z

app/controllers/api/v2/motorcyles_controller.rb

+  end
+
+  def update
+    # @motorcycle = Motorcycle.find(params[:id])


It's better to remove unused code.

mosesogwo · 2022-06-03T20:41:12Z

app/controllers/api/v2/motorcyles_controller.rb

+  end
+
+  def destroy
+    # @motorcycle = Motorcycle.find(params[:id])


It's better to remove unused code.

mosesogwo · 2022-06-03T20:41:30Z

app/controllers/api/v2/reservations_controller.rb

+  end
+
+  def show
+    # show particular motorcycle for reservation


It's better to remove unused code.

mosesogwo

Hi team,

Good job so far!
There are some issues to be handled that will make your project superb.

Highlights

Good job with restful controller actions and keeping best practices.

Suggested Changes ♻️

Revert changes made to the linter config.
Make sure that tests are passing.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

* Validate the presence of a scooter before reservation or delete and throw the right error * fix linters erors * change motocyrcle tp scooter * Add user id to a scooter * Fix linter errors

* Validate the presence of a scooter before reservation or delete and throw the right error * fix linters erors * change motocyrcle tp scooter * Add user id to a scooter * Fix linter errors * Fix scooter bugg

vic778 and others added 30 commits May 13, 2022 10:12

Add gems for test and linters error

025b473

Add factory

12ba5f2

Add cros to give access to anyone

8290d34

Create user controler with the action for creating a user and update

978a872

Add the path route

e93f4be

Create the Api folder that contains the modul for user

d37e0d4

Add the validations presence and add digest to make the password hash…

1d9aea7

…ed bt bcrypt

Migrate the user table

f4fc926

Create foctory to test the user

455b39e

Add ruboccop

7f44c03

Fix linter errors

49b059c

Permit the parms

0b48868

Add route for update and delete

567cb7d

Merge pull request #8 from vic778/register

4f3b0a2

Register

Add login method

e9a413f

Add route to login

263bc74

Change route for login

b3468c3

Fix Linter errors

3a3e65e

Merge pull request #9 from vic778/auth

6657a5e

Sign in

Add test for model and config factorr

5aed8dd

Fix linter error

bf7138a

Test api login

c04c662

Test user request

8499eb9

Test user_spec

c826e03

Fix linters error

206d9d5

Test login via api

7822b82

Change status cose to accepted in authentication spec

75eea23

Test login error

c96a1e9

Test to ensure login returns token and user

2fe497d

Test to ensure login returns correct user

e60e2d0

cwaku and others added 26 commits May 18, 2022 12:18

Add deployment

9825f57

Add heroku link

0265630

Serialize image color model and year

4c5d46b

Update resevation with date and city

150a017

Update schema

0237e67

test api

51b2a30

Update API base url

6f540d0

Fix linter errors

75548de

Merge pull request #15 from vic778/imgbot

840e340

[ImgBot] Optimize images

remove authorization for bike show

df272cb

Validate

77ec593

Remove update availble in the controller

29a796d

Add update after canclel the reservation

aafc8a0

Add dependes destroy for a reservation

42f48b8

Update available byr false after reserving a bik

3259347

Add dependes destory to delete even the bike when the user is deleted

9e021c4

Update the schema

4ce51ad

Remove comment lines

023c6e9

Fix linter error

259b1e1

Update route names

8d1db46

Add set reservation to create method

894046f

Add set scooter to create method

b362c6e

Remove set scooter to create method

8c59c77

reset database

b089dba

reset database

e12fd65

mosesogwo suggested changes Jun 3, 2022

View reviewed changes

vic778 added 2 commits June 7, 2022 15:41

Check the Id before action (#18)

14c6b90

* Validate the presence of a scooter before reservation or delete and throw the right error * fix linters erors * change motocyrcle tp scooter * Add user id to a scooter * Fix linter errors

Change request (#19)

458eceb

* Validate the presence of a scooter before reservation or delete and throw the right error * fix linters erors * change motocyrcle tp scooter * Add user id to a scooter * Fix linter errors * Fix scooter bugg

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Final #17

Final #17

vic778 commented Jun 3, 2022 •

edited by cwaku

Loading

mosesogwo left a comment

mosesogwo Jun 3, 2022

mosesogwo Jun 3, 2022

mosesogwo Jun 3, 2022

mosesogwo Jun 3, 2022

mosesogwo left a comment

Final #17

Are you sure you want to change the base?

Final #17

Conversation

vic778 commented Jun 3, 2022 • edited by cwaku Loading

Note: Click here for the frontend PR

mosesogwo left a comment

Choose a reason for hiding this comment

Highlights

Suggested Changes ♻️

mosesogwo Jun 3, 2022

Choose a reason for hiding this comment

mosesogwo Jun 3, 2022

Choose a reason for hiding this comment

mosesogwo Jun 3, 2022

Choose a reason for hiding this comment

mosesogwo Jun 3, 2022

Choose a reason for hiding this comment

mosesogwo left a comment

Choose a reason for hiding this comment

Highlights

Suggested Changes ♻️

vic778 commented Jun 3, 2022 •

edited by cwaku

Loading