Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dutch internationalization #403

Closed
wants to merge 1 commit into from
Closed

Add Dutch internationalization #403

wants to merge 1 commit into from

Conversation

abigailwillow
Copy link
Contributor

Even though the name doesn't change I added a translation for verbosity sake

@victornpb
Copy link
Owner

Even tho adding this i18n description seems like a no brainer, isn't this misleading? Since the application itself is english only?

I don't have any plans adding internationalization, because it would complicate things.
I want to keep the code as simple as possible for other people.

If you still think it would be valuable to have just the description internationalized, let me know your thoughts.

@abigailwillow
Copy link
Contributor Author

Even tho adding this i18n description seems like a no brainer, isn't this misleading? Since the application itself is english only?

I don't have any plans adding internationalization, because it would complicate things. I want to keep the code as simple as possible for other people.

If you still think it would be valuable to have just the description internationalized, let me know your thoughts.

That definitely makes sense. It's been a while, but if I recall correctly I made this PR in response to a PR that contributed German internationalization. I'd gladly help with translating the rest of the application as well if it is ever implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants