Fix README path for build #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flo4604
reviewed
Oct 9, 2022
| @@ -95,7 +95,7 @@ function updateReadmeOutputTable() { | |||
| return (startIndex !== -1 && endIndex !== -1) ? str.slice(0, startIndex + startString.length) + substitute + str.slice(endIndex) : str; | |||
| } | |||
| const fs = require('fs'); | |||
| const readme = fs.readFileSync('README.md', 'utf8'); | |||
| const readme = fs.readFileSync('readme.md', 'utf8'); | |||
| const outputDescription = generateOutputDescription(config); | |||
| const newReadme = replaceBetween(readme, '<!-- Output table (auto generated do not modify) -->', '<!-- END -->', `\n\n${outputDescription}\n\n`); | |||
| fs.writeFileSync('README.md', newReadme); | |||
There was a problem hiding this comment.
Would it not also make sense to change "README." to "readme" here?
There was a problem hiding this comment.
yes, sorry it works on my end because macos is case insensitive, so I didn't notice the mistake
|
This rollup config was based in my https://github.com/victornpb/template-library-with-rollup template repo, but this part is actually not being used by this project, because undiscord isn't a library. I removed this entire portion of code in #455, so I'm closing this PR because this fix is no longer necessary. But Thank you anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, I get the following error: