Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated index.tsx and home.json with new button text and link #113

Merged
merged 3 commits into from
May 7, 2024

Conversation

Yami-Yam
Copy link
Contributor

changed the button that directs to the discord server to a google forms for the survey

Copy link

codesandbox bot commented Apr 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Apr 19, 2024

@Yami-Yam is attempting to deploy a commit to the Vignette Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vignette-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 2:15pm

Copy link
Member

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping out with the survey and congratulations for your first PR. I know it's daunting but I do have a few nitpicks you can answer.

@@ -4,6 +4,7 @@
"hero-p": "Bring your inner creativity with Vignette, the open source modular streaming toolkit for virtual streaming.",
"join-discord-long": "Join our Discord for updates",
"join-discord-short": "Join our Discord",
"join-survey": "Join our Survey",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds too invasive, maybe something more inviting so we can invite them to take the survey like "Can't wait? Let's get to know each other!"

pages/index.tsx Outdated
@@ -46,17 +46,17 @@ const Home: NextPage<cache> = ({ contributors }) => {
</p>

<Button
href="https://discord.gg/rsPNAxwweg"
href="https://docs.google.com/forms/d/e/1FAIpQLSfqaFTQsKdWxQINWxMgMp_eSy3b37GyiPJhUfKfH-B1Q90dug/viewform"
Copy link
Member

@sr229 sr229 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure the end of this google form backlinks immediately to our Discord? It would be nice to say "Thank you for taking some time to answer some questions! We have a Discord you can join." after they answered the questionnaire.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm currently working on it. Regarding the survey backlinks to a page with a discord invite link, from what I've looked up, I need access to configure the google forms for that but I'm also not so sure if that's the only way to do that. For now, I've set it up so that when users click on the survey button, it opens in a new tab, and the current page redirects to the one with the discord link. Is that okay?

@sr229 sr229 added the enhancement New feature or request label Apr 19, 2024
@sr229
Copy link
Member

sr229 commented Apr 20, 2024

Build errors most likely came from a cache miss, we'll retry.

@sr229
Copy link
Member

sr229 commented Apr 20, 2024

I fixed the errors but please do run yarn lint/pnpm lint before pushing to the repos. You seem to have broken some stuff.

@Yami-Yam
Copy link
Contributor Author

noted, thanks again.

@sr229 sr229 merged commit 24118bb into vignetteapp:master May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants