ADT set (tree) #13
Open
ADT set (tree) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
suggested changes
Nov 9, 2018
| this->previous = nullptr; | ||
| this->next = nullptr; | ||
| data = 0; | ||
| } |
| struct Element | ||
| { | ||
| explicit Element(int data); | ||
| ~Element(); |
| if (isEmpty()) | ||
| { | ||
| cout << "List is empty. Node can not be deleted\n"; | ||
| } |
| } | ||
| else | ||
| { | ||
| this->~List(); |
| while (temp->next != nullptr) | ||
| { | ||
| temp = temp->next; | ||
| } |
| #pragma once | ||
| #include <iostream> | ||
|
|
||
| using namespace std; |
| this->data = 0; | ||
| this->leftChild = nullptr; | ||
| this->rightChild = nullptr; | ||
| } |
| // delete left subtree | ||
| while (head->leftChild != nullptr) | ||
| { | ||
| remove(maximum(head->leftChild)); |
There was a problem hiding this comment.
Как сложно-то. Просто рекурсивно для каждого узла удаляем его потомков, затем его самого. Квадратичная трудоёмкость удаления тут ни к чему :)
| else | ||
| { | ||
| cout << "There is no such menu option: " << number << endl << endl; | ||
| } |
…element as I do not need it. Deleted constructed without pararemtrs as I do need it too
…tructors in element and node. Changed destructor in Set. Added switch instead of if-else in userInterface
yurii-litvinov
approved these changes
Nov 22, 2018
| Element* previous; | ||
| Element* next; | ||
| private: | ||
| Element(); |
| #pragma once | ||
| #include <iostream> | ||
|
|
||
| using namespace std; |
| } | ||
| else | ||
| { | ||
| if (node->data > data) |
There was a problem hiding this comment.
else if лучше без фигурных скобок
| { | ||
| return false; | ||
| } | ||
| l.printInAscendingOrder(); |
There was a problem hiding this comment.
Ну, обход дерева в прямом или обратном порядке делается за линейное время, добавление элементов дерева в сортированный список --- за квадратичное :)
| switch (number) | ||
| { | ||
| case 0: | ||
| break; |
There was a problem hiding this comment.
Не, этот break теперь выходит из ветки case-а, а не из цикла, так что из программы нельзя выйти :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADT set seems ready. It lets user to add the value to set, delete the value from set, check if the value is in the set and it prints elements in ascending and descending orders.