Default to standard error serializer for non-error middleware. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `err` serializer was not defaulting to the standard Error serializer
provided by bunyan when there was no error instance.
In practice this means it won't be set for the logger created by the
default middleware.
It seems common practice to log an error when processing a request then
not let it bubble up to an error middleware. However, in that case the
resulting log unexpectedly logs `err: {}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
errserializer was not defaulting to the standard Error serializer provided by bunyan when there was no error instance.In practice this means it won't be set for the logger created by the default middleware.
It seems common practice to log an error when processing a request then not let it bubble up to an error middleware. However, in that case the resulting log unexpectedly logs
err: {}.