Merge pull request #146 from NI57721/refactor/typeof

refactor: use functions of unknownutil within conditions instead of typeof
vim-skk · Aug 20, 2023 · a9fa215 · a9fa215
2 parents 4d42d04 + 85c9d1d
commit a9fa215
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/denops/skkeleton/kana.ts b/denops/skkeleton/kana.ts
@@ -23,7 +23,7 @@ export function getKanaTable(name = currentKanaTable.get()): KanaTable {
 }
 
 function asKanaResult(result: unknown): KanaResult {
-  if (typeof result === "string") {
+  if (is.String(result)) {
     const fn = functions.get()[result];
     if (!fn) {
       throw Error(`function not found: ${result}`);

diff --git a/denops/skkeleton/main.ts b/denops/skkeleton/main.ts
@@ -40,7 +40,7 @@ type HandleResult = {
 
 // deno-lint-ignore no-explicit-any
 function isOpts(x: any): x is Opts {
-  return typeof x?.key === "string";
+  return is.String(x?.key);
 }
 
 function assertOpts(x: unknown): asserts x is Opts {
@@ -92,7 +92,7 @@ async function init(denops: Denops) {
       .map(async (
         cfg,
       ): Promise<[string, string]> => {
-        if (typeof cfg === "string") {
+        if (is.String(cfg)) {
           return [await homeExpand(cfg, denops), ""];
         } else {
           return [await homeExpand(cfg[0], denops), cfg[1]];