Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make it possible to send multiple keys with handleKey #143

Merged
merged 1 commit into from
Aug 27, 2023
Merged

feat: make it possible to send multiple keys with handleKey #143

merged 1 commit into from
Aug 27, 2023

Conversation

NI57721
Copy link
Contributor

@NI57721 NI57721 commented Aug 16, 2023

handleKeyの key に複数の key を送れるようにしてみました。

@NI57721 NI57721 force-pushed the feature/handle-multiple-keys branch from 56d6fad to 8c2794e Compare August 16, 2023 08:58
@Shougo Shougo requested a review from kuuote August 16, 2023 09:40
@NI57721
Copy link
Contributor Author

NI57721 commented Aug 17, 2023

すみません。
新しく定義したsplitSequentialKeysにバグがあったので(※)、後ほど訂正した上で push しなおします。

※"<C->>"が["<C->", ">"]になってしまうなど

@NI57721 NI57721 force-pushed the feature/handle-multiple-keys branch from 8c2794e to 007e51c Compare August 20, 2023 08:16
@NI57721
Copy link
Contributor Author

NI57721 commented Aug 20, 2023

@kuuote
お待たせしました。
レビューお願いします:pray:

@NI57721 NI57721 force-pushed the feature/handle-multiple-keys branch from 007e51c to 2567ec9 Compare August 20, 2023 10:44
@kuuote
Copy link
Member

kuuote commented Aug 27, 2023

ありがとうございます、放置しててすみません。

@kuuote kuuote merged commit 6e1e648 into vim-skk:main Aug 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuuote kuuote Awaiting requested review from kuuote

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NI57721 @kuuote